Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Fix AR algo #112

Merged
merged 3 commits into from
Dec 2, 2024
Merged

Fix: Fix AR algo #112

merged 3 commits into from
Dec 2, 2024

Conversation

arnaudon
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Nov 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.86%. Comparing base (f34dc8d) to head (e606a22).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #112   +/-   ##
=======================================
  Coverage   97.85%   97.86%           
=======================================
  Files          39       39           
  Lines        2242     2244    +2     
  Branches      302      302           
=======================================
+ Hits         2194     2196    +2     
  Misses         29       29           
  Partials       19       19           
Flag Coverage Δ
pytest 97.86% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
neurots/generate/orientations.py 100.00% <100.00%> (ø)
neurots/generate/section.py 100.00% <100.00%> (ø)
neurots/utils.py 100.00% <100.00%> (ø)

Copy link
Member

@adrien-berchet adrien-berchet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it still a draft?

@arnaudon arnaudon marked this pull request as ready for review December 2, 2024 21:07
@arnaudon arnaudon merged commit 6071796 into main Dec 2, 2024
9 checks passed
@arnaudon arnaudon deleted the fix_ar branch December 2, 2024 21:07
@arnaudon
Copy link
Contributor Author

arnaudon commented Dec 2, 2024

We can release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants