-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add replicas #36
Add replicas #36
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! I've changed the variable name filename_regex
for precision, because a glob pattern is not the same as a regex.
To test the replica code, I've replicated the sample data trivially using symlinks. It's working as expected, except one thing I don't understand on the per-window deltaG curve:
What are these gray lines that deviate from the main data?
@jhenin Those are the forward and backward exponential estimates. They look gray because each replica gets alpha<1 and a different color. I'll have to think about a better way to present this. Maybe we don't really need the exponential estimates? Or we could make them a flag. |
I see. I think these plots are useful, but they should be documented, probably in a legend. |
Conflicts in formatting and PEP8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With a minor fix that I just pushed, this works well.
Ideally, a sample dataset with different data in the replicas would be nice to have, but it's not a show-stopper.
Closes issue #8 : U_nk save/load
Closes issue #32 : replicas