Notebook cleanup #44
Open
Notebook cleanup #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhenin
reviewed
Apr 15, 2024
There was a problem hiding this comment.
I've fixed the parameter order when creating the FEPData objects, swapping detectEQ and the name.
Then I get this error:
TypeError: plot_general() got an unexpected keyword argument 'pdf_type' because this relies on branch add_replicas of the SAFEP repo (possibly an updated version that is not on the public repo, as the name of that option is PDFtype in the version I have).
We need to merge that branch before we merge this.
|
@jhenin I have opened a PR with those changes over in the safep repo: BranniganLab/safep#41 |
… compatibility with safep package
…torial into notebook_cleanup
jhenin
approved these changes
May 7, 2024
|
With current SAFEP module, I get:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To address issue #43
Much of the notebook's code has been removed to a helper module. Data are now encapsulated in dataclasses making the user interface much simpler.