Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sphinx & Plotting Documentation #41

Merged
merged 26 commits into from
May 9, 2024
Merged

Sphinx & Plotting Documentation #41

merged 26 commits into from
May 9, 2024

Conversation

EzryStIago
Copy link
Collaborator

@EzryStIago EzryStIago commented Apr 22, 2024

Guilty of branch creep.
There are actually two main changes here:

  1. Sphinx documentation for read-the-docs
  2. PEP8 compliance of plotting.py

Relates to PR 44 in the tutorial: jhenin/SAFEP_tutorial#44

to avoid errors with Python 3.12
@jhenin jhenin temporarily deployed to github-pages May 7, 2024 15:43 — with GitHub Pages Inactive
Copy link
Collaborator

@jhenin jhenin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed a minor compatibility issue with very recent Python.
The BAR_Estimator_Expanded notebook is not just experimental, it currently doesn't run at all (see messages below). I recommend removing it entirely, or into the Legacy directory. EDIT: this is independent from this PR though, so not blocking for merging this.

---------------------------------------------------------------------------
AttributeError                            Traceback (most recent call last)
[/tmp/ipykernel_356363/3207517847.py](http://172.27.1.46:8888/tmp/ipykernel_356363/3207517847.py) in ?()
     12         EQ = pd.DataFrame([])
     13         for key, group in groups:
     14             group = group[~group.index.duplicated(keep='first')]
     15             test = subsampling.equilibrium_detection(group, group.dropna(axis=1).iloc[:,-1])
---> 16             EQ = EQ.append(test)
     17         u_nk = EQ
     18     else:
     19         affix=f"{affix}_HardEquilibrium"

[/data/jhenin/lib/miniconda3/envs/safep/lib/python3.12/site-packages/pandas/core/generic.py](http://172.27.1.46:8888/data/jhenin/lib/miniconda3/envs/safep/lib/python3.12/site-packages/pandas/core/generic.py) in ?(self, name)
   6295             and name not in self._accessors
   6296             and self._info_axis._can_hold_identifiers_and_holds_name(name)
   6297         ):
   6298             return self[name]
-> 6299         return object.__getattribute__(self, name)

AttributeError: 'DataFrame' object has no attribute 'append'

@EzryStIago
Copy link
Collaborator Author

@jhenin I've incorporated that change. Are we otherwise clear to merge?

@jhenin jhenin merged commit e59aa7d into main May 9, 2024
3 checks passed
@EzryStIago EzryStIago deleted the sphinx branch May 13, 2024 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants