Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

app: boards: add configuration for the mks_canable_v20 board #52

Merged
merged 1 commit into from
Dec 22, 2024
Merged

app: boards: add configuration for the mks_canable_v20 board #52

merged 1 commit into from
Dec 22, 2024

Conversation

KozhinovAlexander
Copy link
Contributor

@KozhinovAlexander KozhinovAlexander commented Dec 19, 2024 •
edited
Loading

Add configuration for the mks_canable_v20 board.

@KozhinovAlexander KozhinovAlexander mentioned this pull request Dec 20, 2024
Open
henrikbrixandersen
henrikbrixandersen requested changes Dec 21, 2024
View reviewed changes
app/boards/makerbase/mks_canable_v20/mks_canable_v20.conf Outdated Show resolved Hide resolved
app/boards/makerbase/mks_canable_v20/mks_canable_v20.conf Outdated Show resolved Hide resolved
app/boards/makerbase/mks_canable_v20/mks_canable_v20.conf Outdated Show resolved Hide resolved
app/boards/makerbase/mks_canable_v20/mks_canable_v20.conf Outdated Show resolved Hide resolved
app/boards/makerbase/mks_canable_v20/mks_canable_v20.conf Outdated Show resolved Hide resolved
app/boards/makerbase/mks_canable_v20/mks_canable_v20.conf Outdated Show resolved Hide resolved
app/boards/makerbase/mks_canable_v20/mks_canable_v20.conf Outdated Show resolved Hide resolved
app/boards/makerbase/mks_canable_v20/mks_canable_v20.overlay Outdated Show resolved Hide resolved
app/boards/makerbase/mks_canable_v20/mks_canable_v20.overlay Outdated Show resolved Hide resolved
app/boards/makerbase/mks_canable_v20/mks_canable_v20.overlay Outdated Show resolved Hide resolved
@henrikbrixandersen
Copy link
Member

A new affordable board supporting CANnectvity

Also, please change the Git commit log to something else. This board is not new, and "affordable" is very subjective.

@KozhinovAlexander KozhinovAlexander changed the title app: boards: add mks_canable_v20 app: boards: add configuration for the mks_canable_v20 board Dec 22, 2024
@KozhinovAlexander
Copy link
Contributor Author

A new affordable board supporting CANnectvity

Also, please change the Git commit log to something else. This board is not new, and "affordable" is very subjective.

Done. I've just followed similiar commits from your PR's for other boards now

@KozhinovAlexander
Copy link
Contributor Author

@henrikbrixandersen Thank you as always for very fast and confident review. I've made all the changes requested. Only one comment I would like to leave in place. Please take a look.

@henrikbrixandersen
Copy link
Member

@KozhinovAlexander Hey, please let the reviewer (in this case me) resolve the comments. It is up to the reviewer (not the author) to determine, if their review comment was resolved.

This is good practice in general, not just in CANnectivity.

Thanks.

@KozhinovAlexander
Copy link
Contributor Author

@KozhinovAlexander Hey, please let the reviewer (in this case me) resolve the comments. It is up to the reviewer (not the author) to determine, if their review comment was resolved.

This is good practice in general, not just in CANnectivity.

Thanks.

Oh. Sure. I see. Of course will do always from now on. Shall I unresolve then?

@henrikbrixandersen
Copy link
Member

Oh. Sure. I see. Of course will do always from now on. Shall I unresolve then?

No need, I unresolved them.

henrikbrixandersen
henrikbrixandersen requested changes Dec 22, 2024
View reviewed changes
Copy link
Member

@henrikbrixandersen henrikbrixandersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! One small nit:

app/boards/makerbase/mks_canable_v20/mks_canable_v20.conf Outdated Show resolved Hide resolved
@KozhinovAlexander
Copy link
Contributor Author

Looks good, thanks! One small nit:

Thank you too a lot. Wish you merry christmas.

henrikbrixandersen
henrikbrixandersen requested changes Dec 22, 2024
View reviewed changes
Copy link
Member

@henrikbrixandersen henrikbrixandersen left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait, you've used the GitHub web UI for applying a fix. Please pull the branch, squash the two commits, and force-push.

@KozhinovAlexander
app: boards: add configuration for the mks_canable_v20 board
c03e938 
Add configuration for the mks_canable_v20 board.

Signed-off-by: Alexander Kozhinov <[email protected]>
@KozhinovAlexander
Copy link
Contributor Author

Wait, you've used the GitHub web UI for applying a fix. Please pull the branch, squash the two commits, and force-push.

Done

@henrikbrixandersen
Copy link
Member

Wait, you've used the GitHub web UI for applying a fix. Please pull the branch, squash the two commits, and force-push.

Done

Thanks. Happy holidays!

@henrikbrixandersen henrikbrixandersen merged commit a7e38d0 into CANnectivity:main Dec 22, 2024
4 checks passed
@KozhinovAlexander KozhinovAlexander deleted the mks_canable_v20 branch December 22, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henrikbrixandersen henrikbrixandersen henrikbrixandersen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KozhinovAlexander @henrikbrixandersen