Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gradient generation tool to support GENN models in FOQUS #1164

Merged
merged 16 commits into from
Sep 29, 2023

Conversation

bpaul4
Copy link
Contributor

@bpaul4 bpaul4 commented Sep 6, 2023

Summary/Motivation:

Gradient generation tool from Brady Gess. Certain machine learning tools train gradient-enhanced neural network (GENN) models which can be more accurate for complex datasets given a priori knowledge of model derivatives. However, the derivatives must be known beforehand and are not often available for process data. This tool automatically predicts the gradients for a training dataset in a form usable by common GENN trainers, such as Surrogate Modeling Toolbox.

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the copyright and license terms described in the LICENSE.md file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@bpaul4 bpaul4 added Priority:Normal Normal Priority Issue or PR ML/AI Machine Learning/Artificial Intelligence labels Sep 6, 2023
@bpaul4 bpaul4 self-assigned this Sep 6, 2023
@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

All modified lines are covered by tests ✅

📢 Thoughts on this report? Let us know!.

@bpaul4 bpaul4 marked this pull request as ready for review September 8, 2023 18:08
@bpaul4
Copy link
Contributor Author

bpaul4 commented Sep 8, 2023

@lbianchi-lbl would it be useful or convenient to add testing, even if that is just a smoke test? I'm also fine overlooking code coverage for this script if that is the only issue.

@bpaul4
Copy link
Contributor Author

bpaul4 commented Sep 18, 2023

@lbianchi-lbl @ksbeattie would be you available to review the methods and documentation? The documentation contains a small example script to call the method and test it. I did not add a smoke test for now, as the example tests are not part of the CI suite.

Copy link
Member

@ksbeattie ksbeattie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty much a rubber stamp here...

Copy link
Contributor

@lbianchi-lbl lbianchi-lbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • The documentation looks thorough (although I didn't review it in depth for accuracy)
  • Similarly for the code; we should figure out if or how to test scripts in the examples directory, but that's a more general discussion that goes beyond this PR

@lbianchi-lbl lbianchi-lbl merged commit 237022b into CCSI-Toolset:master Sep 29, 2023
16 checks passed
@bpaul4 bpaul4 deleted the gradient_generation branch March 1, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ML/AI Machine Learning/Artificial Intelligence Priority:Normal Normal Priority Issue or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants