-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gradient generation tool to support GENN models in FOQUS #1164
Gradient generation tool to support GENN models in FOQUS #1164
Conversation
Codecov ReportAll modified lines are covered by tests ✅ 📢 Thoughts on this report? Let us know!. |
@lbianchi-lbl would it be useful or convenient to add testing, even if that is just a smoke test? I'm also fine overlooking code coverage for this script if that is the only issue. |
@lbianchi-lbl @ksbeattie would be you available to review the methods and documentation? The documentation contains a small example script to call the method and test it. I did not add a smoke test for now, as the example tests are not part of the CI suite. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty much a rubber stamp here...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- The documentation looks thorough (although I didn't review it in depth for accuracy)
- Similarly for the code; we should figure out if or how to test scripts in the
examples
directory, but that's a more general discussion that goes beyond this PR
Summary/Motivation:
Gradient generation tool from Brady Gess. Certain machine learning tools train gradient-enhanced neural network (GENN) models which can be more accurate for complex datasets given a priori knowledge of model derivatives. However, the derivatives must be known beforehand and are not often available for process data. This tool automatically predicts the gradients for a training dataset in a form usable by common GENN trainers, such as Surrogate Modeling Toolbox.
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: