-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Local containers #248
Local containers #248
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does dataingestion.env require any new variables?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By default the docker-compose.yml will read any .env
file. So currently I have the DATABASE_PASSWORD
and KEYCLOAK_ADMIN_PASSWORD
specified in it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't like having two .env
files here. I'll consolidate my new .env
into the existing dataingestion.env
and update the README
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
Quality Gate passedIssues Measures |
* Ignore application-local * Add containers directory * Update docker compose * Add local profile to bootRun * Health check for db * Update gradle * Update README, use dataingestion.env for db and keycloak --------- Co-authored-by: Michael Peels <[email protected]>
Newly added
dataingestion.env
Notes - Previously reviewed
application-local.yaml
for the data-ingestion-service.8.0
to8.10.1
Checklist
Types of changes
What types of changes does this PR introduces?
Testing
gradle build
pass in your local?gradle build
logs attached?