Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create postgresql server and db with relevant resources #393
Create postgresql server and db with relevant resources #393
Changes from 26 commits
67840d0
e51d31a
2f5a345
24ad5e3
64d5ed9
2ebf0f7
8875095
79f013d
095f8d9
a884392
9f4f1c1
cb224ce
537ee13
1878571
0916362
b7b24e0
34025ba
9da59a2
d082319
11a797a
196eca7
78e199c
d201fa5
8f4f912
6b81cc2
2d52961
2423ed1
47014cd
e51c5b5
927d60b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we will still need to add this input as a
.tfvar
from the "Load Input Variables" step, under therun
. This is if we are going that route and not usinggetenv()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh wait.. does the the
azurerm_postgresql_flexible_server
resource not need theobject_id
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it looks like the
tenant_id
and theclient_id
are needed though right?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These have been removed. May be added with the next PR with masking the database credentials.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just notice this as well. this cidr will probably need to be
10.1.4.0/24
and not10.0.4.0/24
to eliminate the chance of crossing on top of each other when both environments are running and to match the pattern of the rest of the cidr's.