Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create postgresql server and db with relevant resources #393

Merged
merged 30 commits into from
Nov 25, 2024

Conversation

marycrawford
Copy link
Collaborator

@marycrawford marycrawford commented Nov 13, 2024

Description

Created Postgres Server and One (1) private facing Postgres Database. Taking security measures to ensure the database secrets are not easily accessible.

Screenshots (if applicable)

Screenshot 2024-11-20 at 10 12 21 PM

Related Issues

Checklist

  • The title of this PR is descriptive and concise.
  • My changes follow the style guidelines of this project.
  • I've let the team know about this PR by linking it in the review channel

@marycrawford marycrawford self-assigned this Nov 13, 2024
@marycrawford marycrawford marked this pull request as draft November 13, 2024 07:42
@marycrawford marycrawford changed the title creating database module and resources for postgresql server and db Create database module and resources for postgresql server and db Nov 13, 2024
@marycrawford marycrawford linked an issue Nov 13, 2024 that may be closed by this pull request
@marycrawford marycrawford requested review from nickclyde and removed request for nickclyde November 13, 2024 08:12
@marycrawford marycrawford linked an issue Nov 18, 2024 that may be closed by this pull request
@marycrawford marycrawford marked this pull request as ready for review November 18, 2024 17:43
@marycrawford marycrawford changed the title Create database module and resources for postgresql server and db Create postgresql server and db with applicable resources Nov 21, 2024
@marycrawford marycrawford changed the title Create postgresql server and db with applicable resources Create postgresql server and db Nov 21, 2024
@marycrawford marycrawford changed the title Create postgresql server and db Create postgresql server and db with relevant resources Nov 21, 2024
@derekadombek derekadombek self-requested a review November 21, 2024 21:15
@@ -50,6 +53,7 @@ runs:
ARM_CLIENT_ID: ${{ inputs.azure-client-id }}
ARM_TENANT_ID: ${{ inputs.azure-tenant-id }}
ARM_SUBSCRIPTION_ID: ${{ inputs.azure-subscription-id }}
ARM_OBJECT_ID: ${{ inputs.azure-object-id }}
Copy link
Collaborator

@derekadombek derekadombek Nov 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we will still need to add this input as a .tfvar from the "Load Input Variables" step, under the run. This is if we are going that route and not using getenv()

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh wait.. does the the azurerm_postgresql_flexible_server resource not need the object_id?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks like the tenant_id and the client_id are needed though right?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These have been removed. May be added with the next PR with masking the database credentials.

derekadombek
derekadombek previously approved these changes Nov 22, 2024
derekadombek
derekadombek previously approved these changes Nov 25, 2024
@@ -18,6 +19,7 @@ locals {
appsubnetcidr = "10.1.1.0/24"
websubnetcidr = "10.1.2.0/24"
lbsubnetcidr = "10.1.3.0/24"
dbsubnetcidr = "10.0.4.0/24"
Copy link
Collaborator

@derekadombek derekadombek Nov 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just notice this as well. this cidr will probably need to be 10.1.4.0/24 and not 10.0.4.0/24 to eliminate the chance of crossing on top of each other when both environments are running and to match the pattern of the rest of the cidr's.

@marycrawford marycrawford added this pull request to the merge queue Nov 25, 2024
Merged via the queue into main with commit e90afae Nov 25, 2024
1 check passed
@marycrawford marycrawford deleted the create-postgres-server-and-db branch November 25, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Postgres Server with one private database
3 participants