Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redo underlying "truth data" sampling #256

Closed
SamuelBrand1 opened this issue Jun 4, 2024 · 2 comments · Fixed by #279
Closed

Redo underlying "truth data" sampling #256

SamuelBrand1 opened this issue Jun 4, 2024 · 2 comments · Fixed by #279
Labels
pipeline

Comments

@SamuelBrand1
Copy link
Collaborator 

          This looks good.

As a note: this PR implies redoing the underlying data generating for the pipeline (which is good and essentially what we are fixing here).

Originally posted by @SamuelBrand1 in #250 (review)

As per title in light of this PR.
@seabbs
Copy link
Collaborator

seabbs commented Jun 11, 2024

Is this done or still in progress?

@SamuelBrand1
Copy link
Collaborator Author

I'm updating this... it makes more sense to also have "truth" day of week effect

This was referenced Jun 12, 2024
Merged
Merged
@SamuelBrand1 SamuelBrand1 linked a pull request Jun 12, 2024 that will close this issue
Implement daily ascertainment in underlying truth data sampling #279
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
pipeline
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement daily ascertainment in underlying truth data sampling CDCgov/Rt-without-renewal
2 participants
@seabbs @SamuelBrand1