Implement daily ascertainment in underlying truth data sampling #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the analysis pipeline so that the truth data is generated with all parameters specified. It closes #256 .
Default daily relative ascertainment
I've fixed the logit relative ascertainment by day of week to$0$ for week days and $-0.5$ for weekends. This translates to a weekend ascertainment being about 60% of the weekday rate. A new parameter constructor has been added that follows similar pattern to other constuctors.
simulateandgenerate_truthdataI've reworked these functions to use
DynamicPPL.fixto simulate with fixed parameters, and save these values. I think this is preferable to the previous pattern of fixing some things and letting others come from sample from specified prior distributions. This means thatDynamicPPLandLogExpFunctionsare direct deps of the pipeline in this PR.Minor issues
simulatewould fail because it couldn't save.