Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 101: Add documention templates #104

Merged
merged 2 commits into from
Mar 1, 2024
Merged

Issue 101: Add documention templates #104

merged 2 commits into from
Mar 1, 2024

Conversation

seabbs
Copy link
Collaborator

@seabbs seabbs commented Mar 1, 2024

This PR closes #101 by adding documentation templates for functions, methods, macros, types, and the overall module.

This is just a first pass and I would appreciate a detailed review as I 1. Found very few real-world examples and 2. Found it very hard to pass how to setup documentation for structs or how to get function documentation to correctly be based on the generic method whilst also documenting the typed fields for specific functions.

@codecov-commenter
Copy link

codecov-commenter commented Mar 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.74%. Comparing base (a8d96a0) to head (e37c4e1).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #104   +/-   ##
=======================================
  Coverage   97.74%   97.74%           
=======================================
  Files           6        6           
  Lines         133      133           
=======================================
  Hits          130      130           
  Misses          3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SamuelBrand1 SamuelBrand1 self-requested a review March 1, 2024 12:57
Copy link
Collaborator

@SamuelBrand1 SamuelBrand1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good first pass.

@SamuelBrand1
Copy link
Collaborator

@seabbs Can you sort the branch conflict?

@seabbs seabbs requested a review from SamuelBrand1 March 1, 2024 13:47
@seabbs seabbs enabled auto-merge March 1, 2024 13:47
@seabbs seabbs merged commit 00c7f43 into main Mar 1, 2024
8 of 9 checks passed
@seabbs seabbs deleted the issue101 branch March 1, 2024 14:01
@seabbs seabbs mentioned this pull request Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a documentation template
3 participants