Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename latent_model_model to latent_model #112

Merged
merged 1 commit into from
Mar 5, 2024
Merged

rename latent_model_model to latent_model #112

merged 1 commit into from
Mar 5, 2024

Conversation

SamuelBrand1
Copy link
Collaborator

This PR fixes #111 .

latent_model_model goes to latent_model as a keyword argument. Internal use of realisations of the latent model are denoted Z_t.

@SamuelBrand1 SamuelBrand1 requested a review from seabbs March 5, 2024 12:25
@SamuelBrand1 SamuelBrand1 linked an issue Mar 5, 2024 that may be closed by this pull request
Change kwarg latent_model_model #111
Closed
@SamuelBrand1
Copy link
Collaborator Author

NB: the choice of Z_t for internal representation of instants of the latent model was due to mathematical description proposed in getting start example committed on #109 .

seabbs
seabbs approved these changes Mar 5, 2024
View reviewed changes
Copy link
Collaborator

@seabbs seabbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. LGTM

@seabbs seabbs merged commit 791d8e2 into main Mar 5, 2024
8 of 9 checks passed
@seabbs seabbs deleted the 111-change-kwarg-latent_model_model branch March 5, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seabbs seabbs seabbs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change kwarg latent_model_model
2 participants
@SamuelBrand1 @seabbs