Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 511: Minimal fix for benchmarkCI #519

Closed
wants to merge 4 commits into from

Conversation

SamuelBrand1
Copy link
Collaborator

This PR is an alternative, and more minimalistic approach to fixing #511 : BenchmarkCI.jl dep is added from a fork of BenchmarkCI, which resolves the compat problem. No other changes to benchmarking is done here.

@SamuelBrand1 SamuelBrand1 requested a review from seabbs November 11, 2024 12:45
Copy link
Contributor

Try this Pull Request!

Open Julia and type:

import Pkg
Pkg.activate(temp=true)
Pkg.add(url="https://github.com/CDCgov/Rt-without-renewal", rev="fix-benchmark-ci2", subdir="EpiAware")
using EpiAware

@SamuelBrand1 SamuelBrand1 changed the base branch from main to sciml-infection-model November 11, 2024 12:46
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.16%. Comparing base (bc701a6) to head (8c24ee8).

Additional details and impacted files
@@                  Coverage Diff                   @@
##           sciml-infection-model     #519   +/-   ##
======================================================
  Coverage                  90.16%   90.16%           
======================================================
  Files                         56       56           
  Lines                        824      824           
======================================================
  Hits                         743      743           
  Misses                        81       81           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SamuelBrand1
Copy link
Collaborator Author

PkgBenchmark: benchmark results written to .benchmarkci/result-target.json
ERROR: /home/runner/work/Rt-without-renewal/Rt-without-renewal is dirty. Please commit/stash your changes before benchmarking a specific commit

Still getting this error message.

@seabbs seabbs closed this Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants