Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: figure 1 script #555

Merged
merged 3 commits into from
Dec 16, 2024
Merged

Fix: figure 1 script #555

merged 3 commits into from
Dec 16, 2024

Conversation

SamuelBrand1
Copy link
Collaborator

This PR fixes the script for creating figure 1 so that it runs with the current inference data structure.

Also, I noted that it was possible for the colours used to be inconsistent; I've refactored the figure generating function to be fully Makie based rather than using the AlgebraOfGraphics frontend package to Makie. The downside (if in fact it is a downside) is that the figureone function is imperative rather than declarative.

Copy link
Contributor

Try this Pull Request!

Open Julia and type:

import Pkg
Pkg.activate(temp=true)
Pkg.add(url="https://github.com/CDCgov/Rt-without-renewal", rev="fix-fig1", subdir="EpiAware")
using EpiAware

@codecov-commenter
Copy link

codecov-commenter commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.96%. Comparing base (ab73d9e) to head (e7c981f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #555   +/-   ##
=======================================
  Coverage   90.96%   90.96%           
=======================================
  Files          60       60           
  Lines         863      863           
=======================================
  Hits          785      785           
  Misses         78       78           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@seabbs seabbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bit of a shame to move away for AoG but looks good.

@seabbs seabbs added this pull request to the merge queue Dec 16, 2024
Merged via the queue into main with commit ccbbed3 Dec 16, 2024
10 checks passed
@seabbs seabbs deleted the fix-fig1 branch December 16, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants