-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Visualize whole tree of infections #55
base: main
Are you sure you want to change the base?
Conversation
Pretty cool!! I'm guessing this is:
I could really use a legend or something! Also, I would have expected to see:
But it looks like this is actually there is one more? This is telling me our default "number of simulated generations" should be 3, not 4? Does "simulated" include the index? I'll break this off as a separate issue (#62) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could definitely work. I have some questions to make sure we're going the right way first.
poetry.lock
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I got an error about matplotlib, see #61
Re: legend and what things are: yes we need one, but I figured we should agree on the aesthetics we liked first. E.g., I also have #64 (which is what I thought I had opened this PR on... oops... but you've got the right interpretation for what's been shown here) which I think is in many ways better, but requires shapes for detection. |
To-dos and to-considers from sync disc:
|
Resolves #24 and #15. Solves #53 along the way because the broken plots that led to were driving me crazy.
Code lives in
ringvax.plot
, and I'm rather tempted to wrap it all up into a plotting object since that would avoid a lot of unneeded passing of objects around (the simulation, plotting parameters, and the plot itself).Colors and styles can and probably should be argued over. I strove to keep things clean and visible first and foremost, but also to use our color palette and keep things accessible. I think this is mostly achieved, except perhaps marking detections which is a bit ugly. I tried delineating detection types by color, instead of shape, but I ran out of colors that were both easy to see on both latent and exposed backgrounds and which were truly distinctive from each other.
To keep some of the plotting-induced post-processing sane, I added infection attributes: the
id
and theinfectees
.