Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dependency #61

Merged
merged 1 commit into from
Dec 27, 2024
Merged

Add dependency #61

merged 1 commit into from
Dec 27, 2024

Conversation

swo
Copy link
Contributor

@swo swo commented Dec 26, 2024

To be merged into #55

  • Add matplotlib dependency (although personally I would have done as much as I could in altair and called it a day; I might demo that to see what that would actually have meant)

@swo swo requested a review from afmagee42 December 26, 2024 18:48
@swo swo changed the title Tree visualization suggestions Add dependency Dec 26, 2024
@swo swo marked this pull request as ready for review December 26, 2024 18:48
@swo swo force-pushed the afm-viz-tree-swo branch from 769011a to 2094dda Compare December 26, 2024 20:11
@afmagee42
Copy link
Contributor

I would have done as much as I could in altair and called it a day

This was honestly the fastest way for me to do it. My brain works better for custom plots when I have complete control like this. I tried altair (and graphviz) a bit for some sort of solution, but altair wants data in its own way and I just want to know where to put what.

@afmagee42 afmagee42 merged commit 1cc642e into afm-viz-tree Dec 27, 2024
2 of 4 checks passed
@afmagee42 afmagee42 deleted the afm-viz-tree-swo branch December 27, 2024 16:23
afmagee42 pushed a commit that referenced this pull request Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants