Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Onboard Marshall Island to UP #16900

Merged
merged 5 commits into from
Dec 27, 2024

Conversation

oslynn
Copy link
Collaborator

@oslynn oslynn commented Dec 23, 2024

This PR onboarding Marshall Island to UP

Test Steps:

  1. Include steps to test these changes

Changes

  • Include a comprehensive list of changes in this PR
  • (For web UI changes) Include screenshots/video of changes

Checklist

Testing

  • Tested locally?
  • Ran ./prime test or ./gradlew testSmoke against local Docker ReportStream container?
  • (For Changes to /frontend-react/...) Ran npm run lint:write?
  • Added tests?

Process

  • Are there licensing issues with any new dependencies introduced?
  • Includes a summary of what a code reviewer should test/verify?
  • Updated the release notes?
  • Database changes are submitted as a separate PR?
  • DevOps team has been notified if PR requires ops support?

Linked Issues

To Be Done

Create GitHub issues to track the work remaining, if any

  • #issue

Specific Security-related subjects a reviewer should pay specific attention to

  • Does this PR introduce new endpoints?
    • new endpoint A
    • new endpoint B
  • Does this PR include changes in authentication and/or authorization of existing endpoints?
  • Does this change introduce new dependencies that need vetting?
  • Does this change require changes to our infrastructure?
  • Does logging contain sensitive data?
  • Does this PR include or remove any sensitive information itself?

If you answered 'yes' to any of the questions above, conduct a detailed Review that addresses at least:

  • What are the potential security threats and mitigations? Please list the STRIDE threats and how they are mitigated
    • Spoofing (faking authenticity)
      • Threat T, which could be achieved by A, is mitigated by M
    • Tampering (influence or sabotage the integrity of information, data, or system)
    • Repudiation (the ability to dispute the origin or originator of an action)
    • Information disclosure (data made available to entities who should not have it)
    • Denial of service (make a resource unavailable)
    • Elevation of Privilege (reduce restrictions that apply or gain privileges one should not have)
  • Have you ensured logging does not contain sensitive data?
  • Have you received any additional approvals needed for this change?

Copy link

github-actions bot commented Dec 23, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

Copy link

github-actions bot commented Dec 23, 2024

Test Results

1 268 tests  ±0   1 264 ✅ ±0   7m 49s ⏱️ +4s
  164 suites ±0       4 💤 ±0 
  164 files   ±0       0 ❌ ±0 

Results for commit d70a959. ± Comparison against base commit ba596b5.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 23, 2024

Integration Test Results

 60 files  ±0   60 suites  ±0   37m 8s ⏱️ +50s
426 tests +1  416 ✅ +1  10 💤 ±0  0 ❌ ±0 
429 runs  +1  419 ✅ +1  10 💤 ±0  0 ❌ ±0 

Results for commit d70a959. ± Comparison against base commit ba596b5.

♻️ This comment has been updated with latest results.

@oslynn oslynn marked this pull request as ready for review December 24, 2024 19:11
@oslynn oslynn requested a review from a team as a code owner December 24, 2024 19:11
@oslynn
Copy link
Collaborator Author

oslynn commented Dec 26, 2024

Need to add integration test to the PR.

--- Done

@oslynn oslynn enabled auto-merge (squash) December 27, 2024 16:19
@oslynn oslynn merged commit 345f93c into main Dec 27, 2024
25 checks passed
@oslynn oslynn deleted the oo/oslynn/14894/Onboarding_Marshall_Island_to_UP branch December 27, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants