[AB2D-6101] Address Critical Code Smell - Reduce cognitive method compleixty #403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rwolfe-Nava
changed the title
Rwolfe-Nava
changed the title
smirnovaae
reviewed
Jul 18, 2024
ab2d-fhir/src/test/java/gov/cms/ab2d/fhir/PatientIdentifierUtilsTest.java
Outdated
Show resolved
Hide resolved
smirnovaae
approved these changes
Jul 18, 2024
ab2d-fhir/src/test/java/gov/cms/ab2d/fhir/PatientIdentifierUtilsTest.java
Outdated
Show resolved
Hide resolved
ab2d-fhir/src/test/java/gov/cms/ab2d/fhir/PatientIdentifierUtilsTest.java
Outdated
Show resolved
Hide resolved
ab2d-fhir/src/test/java/gov/cms/ab2d/fhir/PatientIdentifierUtilsTest.java
Outdated
Show resolved
Hide resolved
ab2d-fhir/src/test/java/gov/cms/ab2d/fhir/PatientIdentifierUtilsTest.java
Outdated
Show resolved
Hide resolved
ab2d-fhir/src/test/java/gov/cms/ab2d/fhir/PatientIdentifierUtilsTest.java
Outdated
Show resolved
Hide resolved
ab2d-fhir/src/test/java/gov/cms/ab2d/fhir/PatientIdentifierUtilsTest.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
https://jira.cms.gov/browse/AB2D-6101
🛠 Changes
Address code smell in IdentifierUtils, reducing single method complexity.
Add test cases to cover new utility methods created to break apart the above method.
Bumps fhir lib version to 1.2.7
ℹ️ Context
This is part of an ongoing effort to pay down tech debt and increase the reliability and maintainability of AB2D's codebase.
🧪 Validation
Tested locally and passing CI checks.