Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AB2D-6101] Address Critical Code Smell - Reduce cognitive method compleixty #403

Merged
merged 13 commits into from
Jul 22, 2024
Merged

[AB2D-6101] Address Critical Code Smell - Reduce cognitive method compleixty #403

merged 13 commits into from
Jul 22, 2024

Commits on Jul 16, 2024

  1. initial commit - first pass at reducing method complexity

    @Rwolfe-Nava
    Rwolfe-Nava committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    5e2c42a View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2024

  1. add missing args

    @Rwolfe-Nava
    Rwolfe-Nava committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    d50c400 View commit details
    Browse the repository at this point in the history

  2. first pass at tests

    @Rwolfe-Nava
    Rwolfe-Nava committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    1f32956 View commit details
    Browse the repository at this point in the history

  3. update tests and address codesmells

    @Rwolfe-Nava
    Rwolfe-Nava committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    4c28ade View commit details
    Browse the repository at this point in the history

  4. update tests

    @Rwolfe-Nava
    Rwolfe-Nava committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    38a9bef View commit details
    Browse the repository at this point in the history

  5. parameterize generic

    @Rwolfe-Nava
    Rwolfe-Nava committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    2df4c0c View commit details
    Browse the repository at this point in the history

  6. bump fhirVersion

    @Rwolfe-Nava
    Rwolfe-Nava committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    9855342 View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2024

  1. update based on review feedback

    @Rwolfe-Nava
    Rwolfe-Nava committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    63a91c8 View commit details
    Browse the repository at this point in the history

  2. fix test method name

    @Rwolfe-Nava
    Rwolfe-Nava committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    43e9027 View commit details
    Browse the repository at this point in the history

  3. add setup methods in test to reduce code duplication

    @Rwolfe-Nava
    Rwolfe-Nava committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    4b91367 View commit details
    Browse the repository at this point in the history

  4. remove redundant variables

    @Rwolfe-Nava
    Rwolfe-Nava committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    dadf0a5 View commit details
    Browse the repository at this point in the history

  5. remove more redundant variables

    @Rwolfe-Nava
    Rwolfe-Nava committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    64c8d14 View commit details
    Browse the repository at this point in the history

  6. fix generic so sonar is happy

    @Rwolfe-Nava
    Rwolfe-Nava committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    4e5e0c5 View commit details
    Browse the repository at this point in the history