Refactor: Pages폴더 css/style 및 assets 분리 #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
최대한 피그마 페이지에 구현되어 있는 것과 유사한 형태로 작성하도록 함 (아래)
이런 식으로 작성하도록 노력함
css 파일 분리는 mainpage 와 introducepage 를 제외하면 거의 없었음 |
|
일단 작업하느라 수고 많았고... 추가로 했으면 하는 것들 정리해둠
|
ljy2855
requested changes
Feb 13, 2024
There was a problem hiding this comment.
이러한 형식의 파일 이름들 모두 camel case로 변경
There was a problem hiding this comment.
Introduce_2.js 경우에는 IntroduceBenefit.js으로 변경하고, components 폴더에 넣어서 관리하면 좋을 듯
There was a problem hiding this comment.
아니면 introduce page내 component니까 의미중복 고려해서 Introduce 빼고 Benefit.js 으로만 변경해도 이해하기 좋을듯
There was a problem hiding this comment.
pages/main_page/ApplyCardMain/MainApplyCard.css -> src/pages/main_page/components/MainApplyCard.css
변경하여 page별로 코드 구조 일치
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
src/pages/. 아래에 있는 JS 파일에 style 태그로 지정되어 있는 style 을 css 파일로 분리
한 파일당 하나의 css 파일을 가지도록 하고, 최소한 하나의 폴더에 하나의 css 파일을 가지도록 함
src/pages/. 아래에 있는 font 와 image 를 assets/font/ 와 assets/images 아래폴더로 이동