-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: Pages폴더 css/style 및 assets 분리 #40
Merged
Changes from 13 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
3dce384
refactor: app.js
8f2ee39
refactor: ImgMain style
Youngho-kr 7f03dbd
refactor: GoToApply
Youngho-kr 594dbda
refactor: ImgMain fix
Youngho-kr 04f0740
refactor: IntroduceMain
Youngho-kr 04c54d5
add: GoToApply
Youngho-kr 19ab4a9
fix: GoToApply button style
Youngho-kr d7804df
refactor: MainApplyCard
Youngho-kr df7e6e2
rename: /login_page/main.js -> Login.js
Youngho-kr 40fd49e
refactor: MainPage images move to assets
Youngho-kr 96dc6ff
refactor: ResultPage images move to assets
Youngho-kr 9c444c3
refactor: DoingPage images move to assets
Youngho-kr ef2d3d8
refactor: ApplyPage images move to assets
Youngho-kr 2d2393d
refactor: Directory structure, file name refactor
Youngho-kr bba5381
rename: layout -> components
Youngho-kr f36d88d
fix: css route
Youngho-kr f60c94d
refactor: ApplyCard, GoToApply components move to components directory
Youngho-kr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,38 @@ | ||
.MainApplyCard { | ||
position: relative; | ||
|
||
text-align: center; | ||
font-style: normal; | ||
|
||
display: flex; | ||
justify-content: center; | ||
align-items: center; | ||
} | ||
|
||
.MainApplyCardBox { | ||
position: relative; | ||
|
||
width: 1320px; | ||
height: 420px; | ||
} | ||
|
||
.MainApplyCardImg { | ||
width: 1300px; | ||
height: 258px; | ||
|
||
border-radius: 15px; | ||
} | ||
|
||
.MainApplyCardLetterBox { | ||
position: absolute; | ||
|
||
top: 70px; | ||
left: 69px; | ||
|
||
font-size: 30px; | ||
font-weight: bold; | ||
} | ||
|
||
.WhiteWord { | ||
color: #ffffff; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
import React from "react"; | ||
|
||
import img from "../../../assets/images/main/main_apply_img.png"; | ||
|
||
import GoToApply from "../components/GoToApply"; | ||
|
||
import "./MainApplyCard.css"; | ||
|
||
const MainApplyCard = () => { | ||
return ( | ||
<div className="MainApplyCard"> | ||
<div className="MainApplyCardBox"> | ||
<img src={img} className="MainApplyCardImg" /> | ||
<div className="MainApplyCardLetterBox WhiteWord"> | ||
2024 1학기 신입부원 모집 | ||
</div> | ||
<GoToApply top="169px" left="1042px" /> | ||
</div> | ||
</div> | ||
); | ||
}; | ||
|
||
export default MainApplyCard; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,136 @@ | ||
.ImgMain { | ||
position: relative; | ||
|
||
/* font-family: 'IBMPlexSans-Regular'; */ | ||
text-align: center; | ||
|
||
display: flex; | ||
justify-content: center; | ||
align-items: center; | ||
flex-direction: column; | ||
} | ||
|
||
.ImgMainBox { | ||
position: relative; | ||
|
||
width: 1920px; | ||
height: 1005px; | ||
|
||
display: flex; | ||
|
||
justify-content: center; | ||
} | ||
|
||
.ImgMainStyle { | ||
position: absolute; | ||
|
||
width: 1920px; | ||
height: 1005px; | ||
} | ||
|
||
.ImgMainBlackBackgroundStyle { | ||
/* position: "relative"; */ | ||
|
||
width: 1920px; | ||
height: 1005px; | ||
|
||
background: black; | ||
} | ||
|
||
.ImgMainGrayFilterStyle { | ||
position: absolute; | ||
|
||
width: 1920px; | ||
height: 1005px; | ||
/* height: 100%; */ | ||
|
||
display: flex; | ||
justify-content: center; | ||
|
||
/* background: rgba(100, 10, 200, 0.6); */ | ||
background: rgba(0, 0, 0, 0.6); | ||
} | ||
|
||
|
||
.ImgMainLetterBox_1 { | ||
position: absolute; | ||
|
||
font-size: 24px; | ||
font-weight: bold; | ||
|
||
top: 805px; | ||
} | ||
|
||
.ImgMainLetterBox_2 { | ||
position: relative; | ||
text-align: left; | ||
|
||
font-weight: bold; | ||
|
||
top: 444px; | ||
left: 310px; | ||
|
||
/* width: 466px; */ | ||
width: 480px; | ||
height: 135px; | ||
} | ||
|
||
.ImgMainLetterBox_2_1{ | ||
display: inline-block; | ||
} | ||
|
||
.ImgMainLetterBox_3 { | ||
position: absolute; | ||
|
||
width: 1300px; | ||
height: 80px; | ||
|
||
text-align: left; | ||
|
||
justify-content: space-between; | ||
display: flex; | ||
|
||
top: 721px; | ||
} | ||
|
||
.ImgMainLetterBox_3_1 { | ||
position: relative; | ||
|
||
/* width: 341px; */ | ||
width: 370px; | ||
|
||
display: inline-block; | ||
justify-content: left; | ||
} | ||
|
||
.WhiteWord { | ||
color: #ffffff; | ||
} | ||
|
||
.BlueWord { | ||
color: #55A9BE; | ||
} | ||
|
||
.ImgMain_1_Title { | ||
font-weight: 700; | ||
font-size: 24px; | ||
line-height: 150%; | ||
} | ||
|
||
.ImgMain_2_Title { | ||
font-weight: 700; | ||
font-size: 30px; | ||
line-height: 150%; | ||
} | ||
|
||
.ImgMain_3_Title { | ||
font-weight: 700; | ||
font-size: 30px; | ||
line-height: 150%; | ||
} | ||
|
||
.ImgMain_3_Content { | ||
font-weight: 400; | ||
font-size: 20px; | ||
line-height: 150%; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이러한 형식의 파일 이름들 모두
camel case
로 변경There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
예시로 하나 적어줘
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Introduce_2.js
경우에는IntroduceBenefit.js
으로 변경하고, components 폴더에 넣어서 관리하면 좋을 듯There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
아니면 introduce page내 component니까 의미중복 고려해서 Introduce 빼고
Benefit.js
으로만 변경해도 이해하기 좋을듯