Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A0-4268: chain-bootstrapper CI #1720

Merged
merged 21 commits into from
May 20, 2024
Merged

A0-4268: chain-bootstrapper CI #1720

merged 21 commits into from
May 20, 2024

Conversation

Marcin-Radecki
Copy link
Contributor

@Marcin-Radecki Marcin-Radecki commented May 13, 2024

Description

This PR contains changes required for feature nets to work from main again. It also adds proper CI support for chain-bootstrapper. Workflows that build aleph-node were merged into one to avoid code duplication. The key subcommand was added to chain-bootstrapper—it does not increase compilation time and is used by the FE engine to bootstrap the chain. Also, there's better coupling between workflows as they output GH Artifact names that other workflows consume.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Testing

Update net tests are omitted since they needs to be fixed on main anyway.

  1. FE create from main - OK
  2. FE created from Mainnet - OK
  3. On push to main workflow test - OK
  4. Nightly pipeline normal session e2e tests - OK
  5. Nightly pipeline e2e tests on featurenet - OK

Actions before merge PR

Replace all A0-4268 and v6 to v7

Companion PRs

https://github.com/Cardinal-Cryptography/featurenet-template/pull/30
Cardinal-Cryptography/github-actions#49

@Marcin-Radecki Marcin-Radecki added this pull request to the merge queue May 20, 2024
Merged via the queue into main with commit fbdf102 May 20, 2024
15 of 16 checks passed
@Marcin-Radecki Marcin-Radecki deleted the A0-4268 branch May 20, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants