A0-4268: Support for chain-bootstrapper in actions #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikolajgs
approved these changes
May 20, 2024
github-merge-queue bot
pushed a commit
to Cardinal-Cryptography/aleph-node
that referenced
this pull request
May 20, 2024
# Description This PR contains changes required for feature nets to work from `main` again. It also adds proper CI support for `chain-bootstrapper`. Workflows that build `aleph-node` were merged into one to avoid code duplication. The `key` subcommand was added to `chain-bootstrapper`—it does not increase compilation time and is used by the FE engine to bootstrap the chain. Also, there's better coupling between workflows as they output GH Artifact names that other workflows consume. ## Type of change Please delete options that are not relevant. - Bug fix (non-breaking change which fixes an issue) - New feature (non-breaking change which adds functionality) ## Testing Update net tests are omitted since they needs to be fixed on `main` anyway. 1. [FE create from `main`](https://github.com/Cardinal-Cryptography/aleph-node/actions/runs/9090690639/job/24983952063) - OK 2. [FE created from Mainnet](https://github.com/Cardinal-Cryptography/aleph-node/actions/runs/9091207050/job/24985384641) - OK 3. [On push to main workflow test](https://github.com/Cardinal-Cryptography/aleph-node/actions/runs/9091734325) - OK 4. [Nightly pipeline normal session e2e tests](https://github.com/Cardinal-Cryptography/aleph-node/actions/runs/9092279244) - OK 5. [Nightly pipeline e2e tests on featurenet](https://github.com/Cardinal-Cryptography/aleph-node/actions/runs/9092281415) - OK ## Actions before merge PR Replace all `A0-4268` and `v6` to `v7` ## Companion PRs Cardinal-Cryptography/featurenet-template#30 Cardinal-Cryptography/github-actions#49
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds generating FQDN image for new crate
chain-bootstrapper.Actions before merge: replace all
A0-4268references tomainand bump allv6tov7.Actions after merge: add
v7tag.Companion PRs:
https://github.com/Cardinal-Cryptography/featurenet-template/pull/30
Cardinal-Cryptography/aleph-node#1720