Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Role approval expiration #675

Merged
merged 80 commits into from
Feb 23, 2024
Merged

Role approval expiration #675

merged 80 commits into from
Feb 23, 2024

Conversation

LarsKemmann
Copy link
Member

No description provided.

@LarsKemmann
Defined new Expired RoleApprovalStatus value & reordered for precedence
2c763c8
@LarsKemmann
Added shared server-side "effective role version approval" calculation
33cbe0a
@LarsKemmann
WIP and unit tests
68de8ac
@LarsKemmann
Code fixes and finished unit testing
c371e18
@LarsKemmann
Enabled C# Dev Kit extension and recommended it over the basic C# one
d7aa079 
The C# Dev Kit extension is licensed for free use on open source projects, so contributors should be able to use it without issues.
@LarsKemmann
Implemented clean client-side chip display of current approval status
7124219
@LarsKemmann
WIP on enabling return of expired status values
0755a99
@LarsKemmann
Continued WIP on returning expired status values - completed draft fo…
befb304 
…r Approvals
@LarsKemmann
Maintaining backwards compatibility in approach for Referrals
955806d
@LarsKemmann
Merge branch 'main' into role-approval-expiration
37f4972
@LarsKemmann
Rewriting the core approval-side calculations using a DateOnlyTimeline
6c5f37b
@LarsKemmann
WIP commit -- need to test & integrate the new DateOnlyTimeline
bf85de5
@LarsKemmann
Extracted Timelines types to a separate library (planning to spin off)
d3ecb5a
@LarsKemmann
TEMPORARY: Removing other projects from solution to aid Timeline testing
43013f0
@LarsKemmann
WIP on unit-testing DateOnlyTimeline, with some fixes
8e122fa
@LarsKemmann
Full test coverage for DateRange struct
4786e81
@LarsKemmann
Full test coverage for DateOnlyTimeline class
213e3fe
@LarsKemmann
Revert "TEMPORARY: Removing other projects from solution to aid Timel…
ab40add 
…ine testing"

This reverts commit 43013f0.
@LarsKemmann
Incorporating Timelines project into CareTogether.Core
74d6dbc
@LarsKemmann
WIP commit on calculating role approval status timelines
3c79cce
@LarsKemmann
TEMPORARY: Removing other projects from solution to aid Timeline testing
4ccdb6c
@LarsKemmann
WIP on designing tagged timelines, complements & differences
0077120
@LarsKemmann LarsKemmann force-pushed the role-approval-expiration branch from b89c9d9 to 0077120 Compare January 22, 2024 18:59
@LarsKemmann
Finished testing CalculateRoleVersionApprovalStatus & cleaned up helpers
cafc801
@LarsKemmann
Finished testing CalculateEffectiveRoleApprovalStatus, fixed CRVAS test
432be5a
@LarsKemmann
Code cleanup
b7df387
@LarsKemmann
WIP on IndividualAPprovalCalculations tests and code cleanup
1cb5a33
@LarsKemmann
WIP - testing IndividualApprovalCalculations
86a8497
@LarsKemmann
Added Equals and GetHashCode overrides for DateOnlyTimeline with tests
0c8f102
@LarsKemmann
Added Equals and GetHashCode overrides for DateRange with tests
146feb3
@LarsKemmann
More tests & overrides for DateOnlyTimeline Equals & GetHashCode
678fca8
@LarsKemmann
Code cleanup & WIP on testing CalculateIndividualRoleVersionApprovalS…
2d6f0cc 
…tatus
@LarsKemmann
Additional conditions to test
05833fc
@LarsKemmann
Finished testing CalculateIndividualRoleRequirementCompletionStatus
356245d
@LarsKemmann
Finished testing CalculateIndividualRoleVersionApprovalStatus
51744c1
@LarsKemmann
Added placeholder tests
23d2167
@LarsKemmann
Whitespace autoformat
f9d122f
@LarsKemmann
Added current status as an auto-calculated property on records
70bea4c
@LarsKemmann
Implemented tracking of effective dates for role removals
c8191e7
@LarsKemmann
Implemented Denied & Inactive status into approval timeline calculations
60e5965
@LarsKemmann
Implemented RoleRemoval updates into Approval calculations
3843767
@LarsKemmann
Updates to integrate the new RoleRemoval type approach
e148a5e
@LarsKemmann
Unit tests for RoleRemoval approval calculations
15244f9
@LarsKemmann
UI fixes for Volunteer Approvals screen to work with the new data model
fad1ee5
@LarsKemmann
Calculating current missing requirements & available applications
ff7b8bd
@LarsKemmann
UI integration progress
9b07e46
@LarsKemmann
Calculation for all (individual & family-based) individual requirements
d66a792
@LarsKemmann
Excluding unnecessary approvals info from JSON serialization
e09175c
@LarsKemmann
Integration of updated calculations into serialized client data model
d428c7b
@LarsKemmann LarsKemmann marked this pull request as ready for review February 23, 2024 16:57
@LarsKemmann LarsKemmann merged commit e5b1b7a into main Feb 23, 2024
2 checks passed
@LarsKemmann LarsKemmann deleted the role-approval-expiration branch February 23, 2024 17:07
LarsKemmann added a commit that referenced this pull request Feb 23, 2024
@LarsKemmann
Revert "Merge pull request #675 from CareTogether/role-approval-expir…
1d6ef0d 
…ation"

This reverts commit e5b1b7a, reversing
changes made to 6ea0ff3.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@LarsKemmann