Code

Role approval expiration#675

Code

Merged

LarsKemmann merged 80 commits intomainCareTogether/CareTogetherCMS:mainfrom role-approval-expirationCareTogether/CareTogetherCMS:role-approval-expirationCopy head branch name to clipboardFeb 23, 2024

+8,872-5,201

Commits

Commits on Aug 4, 2023

• Defined new Expired RoleApprovalStatus value & reordered for precedence

  LarsKemmann

  committed
  2c763c8

• Added shared server-side "effective role version approval" calculation

  LarsKemmann

  committed
  33cbe0a

• WIP and unit tests

  LarsKemmann

  committed
  68de8ac

• Code fixes and finished unit testing

  LarsKemmann

  committed
  c371e18

• Enabled C# Dev Kit extension and recommended it over the basic C# one

  Show description for d7aa079
  LarsKemmann

  committed
  d7aa079

• Implemented clean client-side chip display of current approval status

  LarsKemmann

  committed
  7124219

• WIP on enabling return of expired status values

  LarsKemmann

  committed
  0755a99

Commits on Aug 5, 2023

• Continued WIP on returning expired status values - completed draft for Approvals

  LarsKemmann

  committed
  befb304

• Maintaining backwards compatibility in approach for Referrals

  LarsKemmann

  committed
  955806d

Commits on Jan 21, 2024

• Merge branch 'main' into role-approval-expiration

  LarsKemmann

  committed
  37f4972

• Rewriting the core approval-side calculations using a DateOnlyTimeline

  LarsKemmann

  committed
  6c5f37b

Commits on Jan 22, 2024

• WIP commit -- need to test & integrate the new DateOnlyTimeline

  LarsKemmann

  committed
  bf85de5

• Extracted Timelines types to a separate library (planning to spin off)

  LarsKemmann

  committed
  d3ecb5a

• TEMPORARY: Removing other projects from solution to aid Timeline testing

  LarsKemmann

  committed
  43013f0

• WIP on unit-testing DateOnlyTimeline, with some fixes

  LarsKemmann

  committed
  8e122fa

• Full test coverage for DateRange struct

  LarsKemmann

  committed
  4786e81

• Full test coverage for DateOnlyTimeline class

  LarsKemmann

  committed
  213e3fe

• Revert "TEMPORARY: Removing other projects from solution to aid Timeline testing"

  Show description for ab40add
  LarsKemmann

  committed
  ab40add

• Incorporating Timelines project into CareTogether.Core

  LarsKemmann

  committed
  74d6dbc

• WIP commit on calculating role approval status timelines

  LarsKemmann

  committed
  3c79cce

• TEMPORARY: Removing other projects from solution to aid Timeline testing

  LarsKemmann

  committed
  4ccdb6c

• WIP on designing tagged timelines, complements & differences

  LarsKemmann

  committed
  0077120

• Remaining tests for complements & tagged date ranges, with fixes

  LarsKemmann

  committed
  138594a

Commits on Jan 23, 2024

• Remaining tests for tagged date-only timelines

  LarsKemmann

  committed
  f04f2f7

• Implementation, tests, and fix for forward-only complement & difference

  LarsKemmann

  committed
  694a59a

• Revert "TEMPORARY: Removing other projects from solution to aid Timeline testing"

  Show description for 2988dee
  LarsKemmann

  committed
  2988dee

• Integrating new timeline calculations into ApprovalCalculations

  LarsKemmann

  committed
  9443e88

• Removed TODOs - premature optimizations :)

  LarsKemmann

  committed
  eea8646

• Removing server-side approval "calculations" that are just filters

  Show description for 4f18010
  LarsKemmann

  committed
  4f18010

• Continuing removing server-side time-specific filter "calculations"

  LarsKemmann

  committed
  e9082f4

• Updating calculations to return completion status details vs. filtering

  LarsKemmann

  committed
  af67ed5

Commits on Jan 24, 2024

• Code cleanup

  LarsKemmann

  committed
  fc95496

• Removing the unnecessary double layer of DTO/contracts around approvals

  LarsKemmann

  committed
  ff2afeb

• Starting the process of fixing the return value data contracts

  LarsKemmann

  committed
  d221d80

• Cleaned up the approvals data contracts (outside-in approach)

  LarsKemmann

  committed
  df71318

• Significant refactoring - finished rebuilding IndividualApproval calcs

  LarsKemmann

  committed
  cddb804

• Significant refactoring - continued on FamilyApproval side

  LarsKemmann

  committed
  4f906db

• Finished approval calculation refactoring; need to integrate next

  Show description for d1c66cd
  LarsKemmann

  committed
  d1c66cd

Commits on Jan 25, 2024

• Integrated the changes into PolicyEvaluationEngine

  LarsKemmann

  committed
  2890066

• Code cleanup & starting CombinedFamilyInfoFormatter integration

  LarsKemmann

  committed
  9c54c69

• Code cleanup & removing redundant requirement action validity lookup

  LarsKemmann

  committed
  fa4d846

• More integration of changes - AuthorizationEngine

  LarsKemmann

  committed
  3910956

• Finished integrating changes into API codebase - OData controller

  LarsKemmann

  committed
  32aabd6

• Swagger & TypeScript client codegen

  LarsKemmann

  committed
  9fb1354

• Made unit test helper generic for reuse

  LarsKemmann

  committed
  897dbe5

• Code reorganization for clarity

  LarsKemmann

  committed
  70a6e3a

• Approvals unit tests draft

  LarsKemmann

  committed
  fed27bd

• Reorganizing Approvals unit tests & changing year to 2024 w/ const

  LarsKemmann

  committed
  6b9384a

• TEMPORARY: Commented out existing Approvals tests in order to fix them

  LarsKemmann

  committed
  22327a6

• Added missing Timelines namespace reference

  LarsKemmann

  committed
  de843db

• Updated year for Referrals tests -- HAS IMPACT!

  LarsKemmann

  committed
  32b6d38

Commits on Jan 26, 2024

• Resolved immediate impact of test updates

  LarsKemmann

  committed
  66d2386

Commits on Jan 27, 2024

• WIP

  LarsKemmann

  committed
  66a019a

Commits on Feb 16, 2024

• Finished testing FindRequirementApprovals & fixed a DateOnlyTimeline bug

  LarsKemmann

  committed
  d1e5e3b

• Finished testing CalculateRoleVersionApprovalStatus & cleaned up helpers

  LarsKemmann

  committed
  cafc801

• Finished testing CalculateEffectiveRoleApprovalStatus, fixed CRVAS test

  LarsKemmann

  committed
  432be5a

• Code cleanup

  LarsKemmann

  committed
  b7df387

• WIP on IndividualAPprovalCalculations tests and code cleanup

  LarsKemmann

  committed
  1cb5a33

• WIP - testing IndividualApprovalCalculations

  LarsKemmann

  committed
  86a8497

• Added Equals and GetHashCode overrides for DateOnlyTimeline with tests

  LarsKemmann

  committed
  0c8f102

• Added Equals and GetHashCode overrides for DateRange with tests

  LarsKemmann

  committed
  146feb3

• More tests & overrides for DateOnlyTimeline Equals & GetHashCode

  LarsKemmann

  committed
  678fca8

• Code cleanup & WIP on testing CalculateIndividualRoleVersionApprovalStatus

  LarsKemmann

  committed
  2d6f0cc

Commits on Feb 17, 2024

• Additional conditions to test

  LarsKemmann

  committed
  05833fc

• Finished testing CalculateIndividualRoleRequirementCompletionStatus

  LarsKemmann

  committed
  356245d

• Finished testing CalculateIndividualRoleVersionApprovalStatus

  LarsKemmann

  committed
  51744c1

• Added placeholder tests

  LarsKemmann

  committed
  23d2167

Commits on Feb 18, 2024

• Whitespace autoformat

  LarsKemmann

  committed
  f9d122f

• Added current status as an auto-calculated property on records

  LarsKemmann

  committed
  70bea4c

• Implemented tracking of effective dates for role removals

  LarsKemmann

  committed
  c8191e7

• Implemented Denied & Inactive status into approval timeline calculations

  LarsKemmann

  committed
  60e5965

• Implemented RoleRemoval updates into Approval calculations

  LarsKemmann

  committed
  3843767

• Updates to integrate the new RoleRemoval type approach

  LarsKemmann

  committed
  e148a5e

• Unit tests for RoleRemoval approval calculations

  LarsKemmann

  committed
  15244f9

Commits on Feb 19, 2024

• UI fixes for Volunteer Approvals screen to work with the new data model

  LarsKemmann

  committed
  fad1ee5

• Calculating current missing requirements & available applications

  LarsKemmann

  committed
  ff7b8bd

• UI integration progress

  LarsKemmann

  committed
  9b07e46

Commits on Feb 23, 2024

• Calculation for all (individual & family-based) individual requirements

  LarsKemmann

  committed
  d66a792

• Excluding unnecessary approvals info from JSON serialization

  LarsKemmann

  committed
  e09175c

• Integration of updated calculations into serialized client data model

  LarsKemmann

  committed
  d428c7b