error: unnecessary closure used to substitute value for `Option::None` --> zcash_client_memory/src/mem_wallet/wallet_write.rs:63:22 | 63 | .map(|a| a.next().ok_or_else(|| Self::Error::AccountOutOfRange)) | ^^^^^^^^^--------------------------------------------- | | | help: use `ok_or(..)` instead: `ok_or(Self::Error::AccountOutOfRange)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations

unnecessary closure used to substitute value for `Option::None`: zcash_client_memory/src/mem_wallet/wallet_write.rs#L58

error: unnecessary closure used to substitute value for `Option::None` --> zcash_client_memory/src/mem_wallet/wallet_write.rs:58:32 | 58 | let seed_fingerprint = SeedFingerprint::from_seed(seed.expose_secret()) | ________________________________^ 59 | | .ok_or_else(|| Self::Error::InvalidSeedLength)?; | |______________--------------------------------------------^ | | | help: use `ok_or(..)` instead: `ok_or(Self::Error::InvalidSeedLength)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations = note: `-D clippy::unnecessary-lazy-evaluations` implied by `-D warnings`

using `clone` on type `TransparentAddress` which implements the `Copy` trait: zcash_client_memory/src/mem_wallet/wallet_read.rs#L369

error: using `clone` on type `TransparentAddress` which implements the `Copy` trait --> zcash_client_memory/src/mem_wallet/wallet_read.rs:369:32 | 369 | let addr = output.recipient_address().clone(); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*output.recipient_address()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy = note: `-D clippy::clone-on-copy` implied by `-D warnings`

this expression creates a reference which is immediately dereferenced by the compiler: zcash_client_memory/src/mem_wallet/wallet_read.rs#L364

error: this expression creates a reference which is immediately dereferenced by the compiler --> zcash_client_memory/src/mem_wallet/wallet_read.rs:364:35 | 364 | .contains_key(&outpoint) | ^^^^^^^^^ help: change this to: `outpoint` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `-D clippy::needless-borrow` implied by `-D warnings`

using `Option.and_then(|x| Some(y))`, which is more succinctly expressed as `map(|x| y)`: zcash_client_memory/src/mem_wallet/wallet_read.rs#L350

called `map(..).flatten()` on `Iterator`: zcash_client_memory/src/mem_wallet/wallet_read.rs#L260

error: called `map(..).flatten()` on `Iterator` --> zcash_client_memory/src/mem_wallet/wallet_read.rs:260:14 | 260 | .map(|(txid, height, nf)| { | ______________^ 261 | | self.tx_table 262 | | .get(txid) 263 | | .and_then(|entry| entry.tx_meta.as_ref()) ... | 276 | | }) 277 | | .flatten() | |______________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten = note: `-D clippy::map-flatten` implied by `-D warnings` help: try replacing `map` with `filter_map` and remove the `.flatten()` | 260 ~ .filter_map(|(txid, height, nf)| { 261 + self.tx_table 262 + .get(txid) 263 + .and_then(|entry| entry.tx_meta.as_ref()) 264 + .and_then(|tx| { 265 + tx.sapling_outputs() 266 + .iter() 267 + .find(|o| o.nf() == Some(&nf)) 268 + .map(|o| (*o.account_id(), *o.nf().unwrap())) 269 + .or_else(|| { 270 + tx.sapling_spends() 271 + .iter() 272 + .find(|s| s.nf() == &nf) 273 + .map(|s| (*s.account_id(), *s.nf())) 274 + }) 275 + }) 276 + }) |

manual implementation of `Option::map`: zcash_client_memory/src/mem_wallet/wallet_read.rs#L213

error: manual implementation of `Option::map` --> zcash_client_memory/src/mem_wallet/wallet_read.rs:213:35 | 213 | .filter_map(|account| match account.ufvk() { | ___________________________________^ 214 | | Some(ufvk) => Some((account.id(), ufvk.clone())), 215 | | None => None, 216 | | }) | |_____________^ help: try this: `account.ufvk().map(|ufvk| (account.id(), ufvk.clone()))` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map = note: `-D clippy::manual-map` implied by `-D warnings`

using `Option.and_then(|x| Some(y))`, which is more succinctly expressed as `map(|x| y)`: zcash_client_memory/src/mem_wallet/wallet_read.rs#L196

unnecessary closure used to substitute value for `Option::None`: zcash_client_memory/src/mem_wallet/wallet_write.rs#L63