error: unnecessary closure used to substitute value for `Option::None` --> zcash_client_memory/src/mem_wallet/mod.rs:115:23 | 115 | let note_id = self | _______________________^ 116 | | .received_notes 117 | | .0 118 | | .iter() ... | 121 | | .next() 122 | | .ok_or_else(|| Error::NoteNotFound)?; | |______________---------------------------------^ | | | help: use `ok_or(..)` instead: `ok_or(Error::NoteNotFound)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations

this expression creates a reference which is immediately dereferenced by the compiler: zcash_client_memory/src/mem_wallet/wallet_write.rs#L153

error: this expression creates a reference which is immediately dereferenced by the compiler --> zcash_client_memory/src/mem_wallet/wallet_write.rs:153:64 | 153 | self.insert_received_sapling_note(note_id, &o, spent_in); | ^^ help: change this to: `o` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `-D clippy::needless-borrow` implied by `-D warnings`

you are using an explicit closure for copying elements: zcash_client_memory/src/mem_wallet/wallet_write.rs#L147

error: you are using an explicit closure for copying elements --> zcash_client_memory/src/mem_wallet/wallet_write.rs:147:36 | 147 | let spent_in = o | ____________________________________^ 148 | | .nf() 149 | | .and_then(|nf| self.nullifiers.get(&Nullifier::Sapling(*nf))) 150 | | .and_then(|(height, tx_idx)| self.tx_locator.get(*height, *tx_idx)) 151 | | .map(|x| *x); | |____________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone = note: `-D clippy::map-clone` implied by `-D warnings` help: consider calling the dedicated `copied` method | 147 ~ let spent_in = o 148 + .nf() 149 + .and_then(|nf| self.nullifiers.get(&Nullifier::Sapling(*nf))) 150 ~ .and_then(|(height, tx_idx)| self.tx_locator.get(*height, *tx_idx)).copied(); |

unnecessary closure used to substitute value for `Option::None`: zcash_client_memory/src/mem_wallet/wallet_write.rs#L68

error: unnecessary closure used to substitute value for `Option::None` --> zcash_client_memory/src/mem_wallet/wallet_write.rs:68:22 | 68 | .map(|a| a.next().ok_or_else(|| Self::Error::AccountOutOfRange)) | ^^^^^^^^^--------------------------------------------- | | | help: use `ok_or(..)` instead: `ok_or(Self::Error::AccountOutOfRange)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations

unnecessary closure used to substitute value for `Option::None`: zcash_client_memory/src/mem_wallet/wallet_write.rs#L63

error: unnecessary closure used to substitute value for `Option::None` --> zcash_client_memory/src/mem_wallet/wallet_write.rs:63:32 | 63 | let seed_fingerprint = SeedFingerprint::from_seed(seed.expose_secret()) | ________________________________^ 64 | | .ok_or_else(|| Self::Error::InvalidSeedLength)?; | |______________--------------------------------------------^ | | | help: use `ok_or(..)` instead: `ok_or(Self::Error::InvalidSeedLength)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations = note: `-D clippy::unnecessary-lazy-evaluations` implied by `-D warnings`

manual implementation of `Option::map`: zcash_client_memory/src/mem_wallet/wallet_read.rs#L209

error: manual implementation of `Option::map` --> zcash_client_memory/src/mem_wallet/wallet_read.rs:209:35 | 209 | .filter_map(|account| match account.ufvk() { | ___________________________________^ 210 | | Some(ufvk) => Some((account.id(), ufvk.clone())), 211 | | None => None, 212 | | }) | |_____________^ help: try this: `account.ufvk().map(|ufvk| (account.id(), ufvk.clone()))` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map = note: `-D clippy::manual-map` implied by `-D warnings`

unneeded `return` statement: zcash_client_memory/src/mem_wallet/tables.rs#L184

error: unneeded `return` statement --> zcash_client_memory/src/mem_wallet/tables.rs:184:13 | 184 | return Err(Error::TransactionNotFound(*txid)); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return = note: `-D clippy::needless-return` implied by `-D warnings` = help: remove `return`

redundant field names in struct initialization: zcash_client_memory/src/mem_wallet/tables.rs#L220

error: redundant field names in struct initialization --> zcash_client_memory/src/mem_wallet/tables.rs:220:17 | 220 | txid: txid, | ^^^^^^^^^^ help: replace it with: `txid` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names = note: `-D clippy::redundant-field-names` implied by `-D warnings`

Clippy (MSRV)

Clippy had exited with the 101 exit code

Test on Linux