error: this expression creates a reference which is immediately dereferenced by the compiler --> zcash_client_memory/src/mem_wallet/wallet_write.rs:153:64 | 153 | self.insert_received_sapling_note(note_id, &o, spent_in); | ^^ help: change this to: `o` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `-D clippy::needless-borrow` implied by `-D warnings`

you are using an explicit closure for copying elements: zcash_client_memory/src/mem_wallet/wallet_write.rs#L147

error: you are using an explicit closure for copying elements --> zcash_client_memory/src/mem_wallet/wallet_write.rs:147:36 | 147 | let spent_in = o | ____________________________________^ 148 | | .nf() 149 | | .and_then(|nf| self.nullifiers.get(&Nullifier::Sapling(*nf))) 150 | | .and_then(|(height, tx_idx)| self.tx_locator.get(*height, *tx_idx)) 151 | | .map(|x| *x); | |____________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone help: consider calling the dedicated `copied` method | 147 ~ let spent_in = o 148 + .nf() 149 + .and_then(|nf| self.nullifiers.get(&Nullifier::Sapling(*nf))) 150 ~ .and_then(|(height, tx_idx)| self.tx_locator.get(*height, *tx_idx)).copied(); |

redundant slicing of the whole range: zcash_client_memory/src/mem_wallet/wallet_read.rs#L251

error: redundant slicing of the whole range --> zcash_client_memory/src/mem_wallet/wallet_read.rs:251:49 | 251 | let tx_data = Transaction::read(&raw[..], BranchId::Sprout) | ^^^^^^^^ help: use the original value instead: `raw` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_slicing

redundant slicing of the whole range: zcash_client_memory/src/mem_wallet/wallet_read.rs#L246

error: redundant slicing of the whole range --> zcash_client_memory/src/mem_wallet/wallet_read.rs:246:43 | 246 | Transaction::read(&raw[..], BranchId::for_height(&self.network, height)) | ^^^^^^^^ help: use the original value instead: `raw` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_slicing

redundant slicing of the whole range: zcash_client_memory/src/mem_wallet/wallet_read.rs#L240

error: redundant slicing of the whole range --> zcash_client_memory/src/mem_wallet/wallet_read.rs:240:43 | 240 | Transaction::read(&raw[..], BranchId::for_height(&self.network, height)) | ^^^^^^^^ help: use the original value instead: `raw` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_slicing = note: `-D clippy::redundant-slicing` implied by `-D warnings`

using `Option.and_then(|x| Some(y))`, which is more succinctly expressed as `map(|x| y)`: zcash_client_memory/src/mem_wallet/wallet_read.rs#L225

manual implementation of `Option::map`: zcash_client_memory/src/mem_wallet/wallet_read.rs#L210

error: manual implementation of `Option::map` --> zcash_client_memory/src/mem_wallet/wallet_read.rs:210:35 | 210 | .filter_map(|account| match account.ufvk() { | ___________________________________^ 211 | | Some(ufvk) => Some((account.id(), ufvk.clone())), 212 | | None => None, 213 | | }) | |_____________^ help: try this: `account.ufvk().map(|ufvk| (account.id(), ufvk.clone()))` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map = note: `-D clippy::manual-map` implied by `-D warnings`

you are using an explicit closure for cloning elements: zcash_client_memory/src/mem_wallet/wallet_read.rs#L66

error: you are using an explicit closure for cloning elements --> zcash_client_memory/src/mem_wallet/wallet_read.rs:66:12 | 66 | Ok(self.accounts.get(*account_id as usize).map(|a| a.clone())) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `cloned` method: `self.accounts.get(*account_id as usize).cloned()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone = note: `-D clippy::map-clone` implied by `-D warnings`

unneeded `return` statement: zcash_client_memory/src/mem_wallet/tables.rs#L205

error: unneeded `return` statement --> zcash_client_memory/src/mem_wallet/tables.rs:205:13 | 205 | return Err(Error::TransactionNotFound(*txid)); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return = note: `-D clippy::needless-return` implied by `-D warnings` = help: remove `return`

variant name ends with the enum's name: zcash_client_memory/src/error.rs#L32

error: variant name ends with the enum's name --> zcash_client_memory/src/error.rs:32:5 | 32 | IoError(std::io::Error), | ^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names = note: `-D clippy::enum-variant-names` implied by `-D warnings`

redundant field names in struct initialization: zcash_client_memory/src/mem_wallet/tables.rs#L244

error: redundant field names in struct initialization --> zcash_client_memory/src/mem_wallet/tables.rs:244:17 | 244 | txid: txid, | ^^^^^^^^^^ help: replace it with: `txid` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names = note: `-D clippy::redundant-field-names` implied by `-D warnings`

Clippy (MSRV)

Clippy had exited with the 101 exit code

Test on Linux