Skip to content

Merge pull request #2 from ChainSafe/willem/get_transparent_balances

Sign in for the full log view
GitHub Actions / Clippy (MSRV) failed Aug 21, 2024 in 0s

Clippy (MSRV)

4 errors

Details

Results

Message level Amount
Internal compiler error 0
Error 4
Warning 0
Note 0
Help 0

Versions

  • rustc 1.70.0 (90c541806 2023-05-31)
  • cargo 1.70.0 (ec8a8a0ca 2023-04-25)
  • clippy 0.1.70 (90c5418 2023-05-31)

Annotations

Check failure on line 58 in zcash_client_memory/src/mem_wallet/wallet_write.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (MSRV)

unnecessary closure used to substitute value for `Option::None`

error: unnecessary closure used to substitute value for `Option::None`
  --> zcash_client_memory/src/mem_wallet/wallet_write.rs:58:22
   |
58 |             .map(|a| a.next().ok_or_else(|| Self::Error::AccountOutOfRange))
   |                      ^^^^^^^^^---------------------------------------------
   |                               |
   |                               help: use `ok_or(..)` instead: `ok_or(Self::Error::AccountOutOfRange)`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations

Check failure on line 54 in zcash_client_memory/src/mem_wallet/wallet_write.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (MSRV)

unnecessary closure used to substitute value for `Option::None`

error: unnecessary closure used to substitute value for `Option::None`
  --> zcash_client_memory/src/mem_wallet/wallet_write.rs:53:32
   |
53 |           let seed_fingerprint = SeedFingerprint::from_seed(seed.expose_secret())
   |  ________________________________^
54 | |             .ok_or_else(|| Self::Error::InvalidSeedLength)?;
   | |______________--------------------------------------------^
   |                |
   |                help: use `ok_or(..)` instead: `ok_or(Self::Error::InvalidSeedLength)`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations
   = note: `-D clippy::unnecessary-lazy-evaluations` implied by `-D warnings`

Check failure on line 264 in zcash_client_memory/src/mem_wallet/wallet_read.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (MSRV)

using `clone` on type `TransparentAddress` which implements the `Copy` trait

error: using `clone` on type `TransparentAddress` which implements the `Copy` trait
   --> zcash_client_memory/src/mem_wallet/wallet_read.rs:264:32
    |
264 |                     let addr = output.recipient_address().clone();
    |                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*output.recipient_address()`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
    = note: `-D clippy::clone-on-copy` implied by `-D warnings`

Check failure on line 259 in zcash_client_memory/src/mem_wallet/wallet_read.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (MSRV)

this expression creates a reference which is immediately dereferenced by the compiler

error: this expression creates a reference which is immediately dereferenced by the compiler
   --> zcash_client_memory/src/mem_wallet/wallet_read.rs:259:35
    |
259 |                     .contains_key(&outpoint)
    |                                   ^^^^^^^^^ help: change this to: `outpoint`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
    = note: `-D clippy::needless-borrow` implied by `-D warnings`