-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed lerna
from build_scripts
#18180
Conversation
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/[email protected], npm/[email protected] |
Pull Request Test Coverage Report for Build 9516592192Details
💛 - Coveralls |
…nge mac dlopen problemFixed lint errors
Pull Request Test Coverage Report for Build 9536484023Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reads ok, but presumably someone actually familiar with npm etc should give a review as well. thanks.
Pull Request Test Coverage Report for Build 9555854453Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Very nice , thanks Izumi - always nice to simplify and cleanup scripts |
Use
lerna
inchia-blockchain-gui
instead of the one installed inbuild_scripts/npm_{linux,macos,windows}/