Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update project register routing #977

Merged
merged 1 commit into from
Nov 15, 2024
Merged

Update project register routing #977

merged 1 commit into from
Nov 15, 2024
+3 −9

Conversation

kroenlein
Copy link
Collaborator

Citrine Python PR

Fast follow for #974 for unincluded file.

PR Type:

  • Breaking change (fix or feature that would cause existing functionality to change)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Maintenance (non-breaking change to assist developers)

Adherence to team decisions

  • I have added tests for 100% coverage
  • I have written Numpy-style docstrings for every method and class.
  • I have communicated the downstream consequences of the PR to others.
  • I have bumped the version in __version__.py

@kroenlein kroenlein requested a review from a team as a code owner November 15, 2024 16:18
@kroenlein kroenlein merged commit ce9b368 into main Nov 15, 2024
16 checks passed
@kroenlein kroenlein deleted the bugfix/use-generic-for-project-register branch November 15, 2024 16:27
@robbtraister robbtraister mentioned this pull request Nov 15, 2024
Merged
@pacdaemon pacdaemon mentioned this pull request Nov 15, 2024
Merged
@robbtraister robbtraister mentioned this pull request Nov 15, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pacdaemon pacdaemon pacdaemon approved these changes

@andyczerwonka andyczerwonka Awaiting requested review from andyczerwonka

@robbtraister robbtraister Awaiting requested review from robbtraister

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kroenlein @pacdaemon