Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CASMCMS-8835: Do not prematurely filter out disabled nodes #224

Merged
merged 1 commit into from
Oct 17, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## Unreleased
### Fixed
- Make the include_disabled option work as intended.
- Return the correct object from hsm's get_components call when there are no nodes in the session.

## [2.9.0] - 09-29-2023
Expand Down
2 changes: 1 addition & 1 deletion src/bos/operators/power_off_forceful.py
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ def filters(self):
BOSQuery(enabled=True, status=','.join([Status.power_off_forcefully_called,
Status.power_off_gracefully_called])),
TimeSinceLastAction(seconds=options.max_power_off_wait_time),
HSMState(enabled=True),
HSMState(),
]

def _act(self, components):
Expand Down
2 changes: 1 addition & 1 deletion src/bos/operators/power_off_graceful.py
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ def name(self):
def filters(self):
return [
BOSQuery(enabled=True, status=Status.power_off_pending),
HSMState(enabled=True),
HSMState(),
]

def _act(self, components):
Expand Down
2 changes: 1 addition & 1 deletion src/bos/operators/power_on.py
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ def name(self):
def filters(self):
return [
BOSQuery(enabled=True, status=Status.power_on_pending),
HSMState(enabled=True)
HSMState()
]

def _act(self, components):
Expand Down
2 changes: 1 addition & 1 deletion src/bos/operators/session_setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@ def _apply_arch(self, nodes, arch):
valid_archs = set([arch])
if arch == 'X86':
valid_archs.add('UNKNOWN')
hsm_filter = HSMState(enabled=True)
hsm_filter = HSMState()
return set(hsm_filter.filter_by_arch(nodes, valid_archs))

def _apply_limit(self, nodes):
Expand Down