WIP - CASM-4977: Procedure to upgrade NCN and CN with different CSM version based images #5578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajeshranganathan-hpe
force-pushed
the
CASM-4977
branch
2 times, most recently
from
ec39582 to
2bd773e
Compare
rajeshranganathan-hpe
requested review from
Pankhuri-Rajesh,
Srinivas-Anand-HPE,
leliasen-hpe and
atifsyedali
Pankhuri-Rajesh
approved these changes
Nov 29, 2024
rajeshranganathan-hpe
force-pushed
the
CASM-4977
branch
from
2bd773e to
c8e4d12
Compare
Srinivas-Anand-HPE
approved these changes
Nov 29, 2024
leliasen-hpe
reviewed
Dec 3, 2024
Comment on lines
18
to
21
| 1. Go through the product versions file for the higher version and come up with a set | ||
| of products which have to be upgraded for the recipe. In the above example, the | ||
| products from **`x.y.z`** which should be upgraded for CSM version **`1.6.x`** | ||
| should be selected. |
There was a problem hiding this comment.
Could you reword this a bit? It is unclear to me how you would know which products have to be upgraded.
There was a problem hiding this comment.
Please review and confirm if it looks better now
|
|
||
| ## Post install Testing | ||
|
|
||
| Run required tests to ensure that the upgrade works for the intended use cases. |
There was a problem hiding this comment.
Could this be more specific? Should the normal post install checks be executed and could a link to the post install checks be added?
There was a problem hiding this comment.
Changed
rajeshranganathan-hpe
force-pushed
the
CASM-4977
branch
from
1468cc5 to
ec4bf29
Compare
rajeshranganathan-hpe
requested review from
leliasen-hpe,
Pankhuri-Rajesh and
Srinivas-Anand-HPE
leliasen-hpe
reviewed
Dec 4, 2024
Comment on lines
+21
to
+23
| 1. Go through the `product_vars.yaml` file of both the recipes and come up with a set | ||
| of products and versions across the recipes which have to be upgraded for CSM version **`1.6.x`**. |
There was a problem hiding this comment.
How do they know which products should be upgraded. Should be all products with a new version in the latest recipe?
rajeshranganathan-hpe
force-pushed
the
CASM-4977
branch
from
04cb1e7 to
a430bbc
Compare
|
This pull-request has not had activity in over 20 days and is being marked as stale. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Document procedure to upgrade management and managed nodes with different versions of CSM images.
Checklist
.github/CODEOWNERSwith the corresponding team in Cray-HPE.