This repository has been archived by the owner on Aug 13, 2024. It is now read-only.
generated from Cray-HPE/metal-template
-
Notifications
You must be signed in to change notification settings - Fork 1
MTL-2422 -- SLES 15.6 -- CSM 1.6 #708
Draft
jpdavis-prof
wants to merge
19
commits into
main
Choose a base branch
from
SP6
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
downgrade libicu75 to libicu73 downgrade metal-ipxe
After Kernel 6.0.1 `nf_conntrack_helper` was removed. To replace it, an iptables prerouting rule can be implemented to help TFTP/UDP packets properly return through a NAT. This allows TFTP to work from Kubernetes in SLES-15-SP6.
In some environments such as vShasta, we may not have an `ipam` key in the `ds.meta-data` dictionary. Assuming the key exists causes the template engine to fail. This file is templated by our `net-init.sh` script, the failure causes that script to exit early.
Since not all of `net-init.sh` has been confirmed to work when `ipam` isn't defined, and due to `iptables_config`'s criticality, run `iptables_config` earlier at a point we know works without `ipam` set.
Adds a `ExecCondition` that checks whether our `/etc/iptables/metal.conf` file exists before trying to start. This will more clearly state why the service failed instead of leaving the `ExecStart` command output to the user to interpret. Alpha-sorts the properties.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary and Scope
https://jira-pro.it.hpe.com:8443/browse/MTL-2422
Issue Type
Prerequisites
Risks and Mitigations