Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRAYSAT-1649: Added ability for paths with a ~ to be unwrapped #48

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

ethanholen-hpe
Copy link
Contributor

@ethanholen-hpe ethanholen-hpe commented Nov 22, 2024

Summary and Scope

add error logging when unable to find token file path and unwrap ~ as home directory

Is this change backwards incompatible, backwards compatible, or a backwards compatible bugfix?

Issues and Related PRs

List and characterize relationship to Jira/Github issues and other pull requests. Be sure to list dependencies.

Testing

List the environments in which these changes were tested.

Tested on:

  • Rocket
  • Drax
  • Local development environment

Test description:

Risks and Mitigations

Are there known issues with these changes? Any other special considerations?

No

Pull Request Checklist

  • Version number(s) incremented, if applicable
  • Copyrights updated
  • License file intact
  • Target branch correct
  • CHANGELOG.md updated
  • Testing is appropriate and complete, if applicable
  • HPC Product Announcement prepared, if applicable

Copy link
Contributor

@haasken-hpe haasken-hpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple minor comments.

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@ethanholen-hpe ethanholen-hpe merged commit b9766f5 into main Dec 10, 2024
3 checks passed
@ethanholen-hpe ethanholen-hpe deleted the CRAYSAT-1649 branch December 10, 2024 18:50
@ethanholen-hpe ethanholen-hpe changed the title CRAYSAT-1649: add error logging when unable to find token file path CRAYSAT-1649: Added ability for paths with a ~ to be unwrapped Dec 10, 2024
@ethanholen-hpe
Copy link
Contributor Author

/backport release/2.3

Copy link

Backporting into branch release/2.3 was successful. New PR: #51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants