Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRAYSAT-1649: add error logging when unable to find token file path #293

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

ethanholen-hpe
Copy link
Contributor

@ethanholen-hpe ethanholen-hpe commented Nov 26, 2024

Summary and Scope

add error logging when unable to find token file path and unwrap ~ as home directory

Issues and Related PRs

Testing

List the environments in which these changes were tested.

Tested on:

  • Rocket
  • Drax
  • Local development environment

Test description:

How were the changes tested and success verified? If schema changes were part of this change, how were those handled in your upgrade/downgrade testing?

  • Were the install/upgrade-based validation checks/tests run (goss tests/install-validation doc)?
  • Were continuous integration tests run? If not, why?
  • Was upgrade tested? If not, why?
  • Was downgrade tested? If not, why?
  • Were new tests (or test issues/Jiras) created for this change?

Risks and Mitigations

Are there known issues with these changes? Any other special considerations?

Pull Request Checklist

  • Version number(s) incremented, if applicable
  • Copyrights updated
  • License file intact
  • Target branch correct
  • CHANGELOG.md updated
  • Testing is appropriate and complete, if applicable
  • HPC Product Announcement prepared, if applicable

@ethanholen-hpe
Copy link
Contributor Author

ethanholen-hpe commented Nov 26, 2024

@ethanholen-hpe
Copy link
Contributor Author

Copy link
Contributor

@haasken-hpe haasken-hpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Minor comments.

requirements-dev.lock.txt Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
tests/cli/bootsys/test_service_activity.py Show resolved Hide resolved
tests/cli/firmware/test_firmware.py Outdated Show resolved Hide resolved
@ethanholen-hpe ethanholen-hpe marked this pull request as ready for review December 10, 2024 17:16
@ethanholen-hpe ethanholen-hpe merged commit 84043a3 into main Dec 10, 2024
3 checks passed
@ethanholen-hpe ethanholen-hpe deleted the CRAYSAT-1649 branch December 10, 2024 20:52
@ethanholen-hpe
Copy link
Contributor Author

/backport release/3.33

Copy link

Backporting into branch release/3.33 was successful. New PR: #297

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants