Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Env vars de/serialization for formulation #486

Merged
merged 5 commits into from
Nov 23, 2024
Merged

Conversation

mr-zepol
Copy link
Contributor

This PR introduces key improvements following extensive testing across various scenarios.

It addresses issues with the de/serialization process for formulation, particularly in handling environment variables, which were previously inconsistent. To resolve these issues, a new class structure has been implemented that better aligns with the schema definition.

Note: This update includes some breaking changes. However, given the nature of the changes, they are unlikely to impact current usage, as no related issues have been reported thus far.

@mr-zepol mr-zepol requested a review from a team as a code owner August 25, 2024 02:19
@mr-zepol mr-zepol requested review from a team and removed request for a team August 25, 2024 02:19
@mr-zepol mr-zepol force-pushed the Env_vars_issue branch 2 times, most recently from edc00ce to b26d92b Compare August 25, 2024 02:25
Copy link

codacy-production bot commented Aug 25, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.75% 89.47%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (dde0024) 6033 4403 72.98%
Head commit (512dbce) 6137 (+104) 4525 (+122) 73.73% (+0.75%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#486) 228 204 89.47%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@mr-zepol mr-zepol added bug Something isn't working enhancement New feature or request labels Sep 2, 2024
@mr-zepol mr-zepol requested a review from nscuro September 2, 2024 01:08
@mr-zepol mr-zepol force-pushed the Env_vars_issue branch 2 times, most recently from b841a62 to 15aecb8 Compare September 4, 2024 21:46
@mr-zepol
Copy link
Contributor Author

mr-zepol commented Sep 4, 2024

Fixed Compilation Issues

@mr-zepol mr-zepol force-pushed the Env_vars_issue branch 2 times, most recently from 95ad41f to 512dbce Compare September 4, 2024 23:00
@nscuro
Copy link
Member

nscuro commented Sep 5, 2024

@mr-zepol Note: This update includes some breaking changes. However, given the nature of the changes, they are unlikely to impact current usage, as no related issues have been reported thus far.

While I technically agree, I do think we need to take semver a bit more seriously. Last time we released breaking changes in a bugfix version (by my mistake). So I'd suggest we bump the library version to 10.0.0-SNAPSHOT for this:

<version>9.0.6-SNAPSHOT</version>

WDYT?

@mr-zepol
Copy link
Contributor Author

mr-zepol commented Sep 9, 2024

@mr-zepol Note: This update includes some breaking changes. However, given the nature of the changes, they are unlikely to impact current usage, as no related issues have been reported thus far.

While I technically agree, I do think we need to take semver a bit more seriously. Last time we released breaking changes in a bugfix version (by my mistake). So I'd suggest we bump the library version to 10.0.0-SNAPSHOT for this:

<version>9.0.6-SNAPSHOT</version>

WDYT?

Yes, that makes sense, so IMO what we should do is merge the other PRs we have, have a normal release, and then this one

@nscuro
Copy link
Member

nscuro commented Sep 10, 2024

@mr-zepol Good suggestion!

@nscuro nscuro added this to the 10.0.0 milestone Sep 10, 2024
@mr-zepol
Copy link
Contributor Author

@mr-zepol Good suggestion!

So I will create smaller PRs for this one that we can merge before introducing the actual breaking changes, so we have a release with all the improvements.

@nscuro nscuro mentioned this pull request Sep 13, 2024
@mr-zepol mr-zepol force-pushed the Env_vars_issue branch 2 times, most recently from 64fec17 to ab16d6c Compare September 14, 2024 03:36
Copy link

codacy-production bot commented Sep 14, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.26% 94.19%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (16276f9) 6052 4452 73.56%
Head commit (14cdc47) 6113 (+61) 4513 (+61) 73.83% (+0.26%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#486) 155 146 94.19%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@mr-zepol
Copy link
Contributor Author

@nscuro since we have a new release with the previous changes, this one can be merged now

Signed-off-by: Alex Alzate <[email protected]>
@nscuro nscuro removed the enhancement New feature or request label Nov 23, 2024
@nscuro nscuro merged commit b3d1783 into master Nov 23, 2024
10 checks passed
@nscuro nscuro deleted the Env_vars_issue branch November 23, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants