-
-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Env vars de/serialization for formulation #486
Conversation
edc00ce
to
b26d92b
Compare
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
b841a62
to
15aecb8
Compare
Fixed Compilation Issues |
95ad41f
to
512dbce
Compare
While I technically agree, I do think we need to take semver a bit more seriously. Last time we released breaking changes in a bugfix version (by my mistake). So I'd suggest we bump the library version to Line 26 in dde0024
WDYT? |
Yes, that makes sense, so IMO what we should do is merge the other PRs we have, have a normal release, and then this one |
@mr-zepol Good suggestion! |
So I will create smaller PRs for this one that we can merge before introducing the actual breaking changes, so we have a release with all the improvements. |
64fec17
to
ab16d6c
Compare
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
ab16d6c
to
485826e
Compare
485826e
to
9494f3a
Compare
@nscuro since we have a new release with the previous changes, this one can be merged now |
Signed-off-by: Alex Alzate <[email protected]>
Signed-off-by: Alex Alzate <[email protected]>
Signed-off-by: Alex Alzate <[email protected]>
Signed-off-by: Alex Alzate <[email protected]>
Signed-off-by: Alex Alzate <[email protected]>
9494f3a
to
14cdc47
Compare
This PR introduces key improvements following extensive testing across various scenarios.
It addresses issues with the de/serialization process for formulation, particularly in handling environment variables, which were previously inconsistent. To resolve these issues, a new class structure has been implemented that better aligns with the schema definition.
Note: This update includes some breaking changes. However, given the nature of the changes, they are unlikely to impact current usage, as no related issues have been reported thus far.