Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We need to actually flush the async File to ensure everything gets written. #48

Merged
merged 2 commits into from
Nov 29, 2023

Conversation

oli-obk
Copy link
Collaborator

@oli-obk oli-obk commented Nov 29, 2023

The Drop impl won't do it for us like the Drop impl of std::fs::File does

fixes #46

@oli-obk oli-obk merged commit 8cfba52 into DerKarlos:main Nov 29, 2023
7 checks passed
@oli-obk oli-obk deleted the cache branch November 29, 2023 10:28
@DerKarlos
Copy link
Owner

DerKarlos commented Nov 29, 2023

No file errors any more. No glb - log outputs either, I added it again.
But: (the cache is filled)
After about a minute, anything gets slow, 3-4 ms/frame
or / and stops loading tiles.
I added log for cache write read, still testing ...

@oli-obk
Copy link
Collaborator Author

oli-obk commented Nov 29, 2023

log outputs either, I added it again.

it's so spammy, which is why I removed it. Can we move it to debug instead? so it isn't shown by default, but can still be enabled?

@oli-obk
Copy link
Collaborator Author

oli-obk commented Nov 29, 2023

After about a minute, anything gets slow, 3-4 ms/frame

maybe we're loading/unloading tiles at the sky boundary all the time?

@DerKarlos
Copy link
Owner

DerKarlos commented Nov 29, 2023

debug! is fine (It's a run option, isn't it? YES! THAT's IT: %RUST_LOG=debug cargo run)
So we need more debug for un/loading :-)
I try to do it ...
NO, (with info!) I do see no despawn_recursive
Do you have the same behaviour?

@DerKarlos
Copy link
Owner

DerKarlos commented Nov 29, 2023

With Web it's about the same: gets really slow. Tile loading seems to stop but takes just a minute.
The trouble starts only if you move some way to cause new tile loads.
(Don't hurry, I have other things to explore)

This is an interesting case. I! should be able to find the cause. By adding logs or by debugging....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cache issues
2 participants