Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We need to actually flush the async File to ensure everything gets written. #48

Merged
merged 2 commits into from
Nov 29, 2023
Merged

We need to actually flush the async File to ensure everything gets written. #48

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c80331d
We need to actually flush the async File to ensure everything gets wr…
oli-obk Nov 29, 2023
6468b33
Update bevy_web_asset repository to latest changes
oli-obk Nov 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion src/http_assets.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,9 @@ impl AssetReader for HttpAssetReader {
// Write asset to cache, but ensure only one HttpAssetReader writes at any given point in time
if self.sync.write().unwrap().insert(cache_path.clone()) {
async_fs::create_dir_all(cache_path.parent().unwrap()).await?;
File::create(&cache_path).await?.write_all(&bytes).await?;
let mut file = File::create(&cache_path).await?;
file.write_all(&bytes).await?;
file.flush().await?;
}
}
Ok(Box::new(VecReader::new(bytes)) as Box<Reader<'static>>)
Expand Down