Upgrade spdlog dependency to 1.12 #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The spdlog library introduced some non-backward-compatible changes between version 1.9.2 (packaged with Ubuntu 22.04) and version 1.12 (packaged with Ubuntu 24.04). Specifically, standard library containers are only log-printable if the new header <spdlog/fmt/ranges.h> is included, and user-defined types are only log-printable if they explicitly specialize fmt::formatter<T> (including <spdlog/fmt/ostr.h> is no longer sufficient).
|
Note: The "build check" on GitHub seems to have failed because the GitHub test servers are still using Ubuntu 22.04 when build.yml specifies "ubuntu-latest" (even though 24.04 is now the latest LTS version). I ran regression tests on Fractus, where I could manually install spdlog 1.12, and confirmed that this branch compiles and runs with bandwidth_test and typed_bandwidth_test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The spdlog library introduced some non-backward-compatible changes between version 1.9.2 (packaged with Ubuntu 22.04) and version 1.12 (packaged with Ubuntu 24.04). Specifically, standard library containers are only log-printable if the new header
<spdlog/fmt/ranges.h>is included, and user-defined types are only log-printable if they explicitly specializefmt::formatter<T>-- including<spdlog/fmt/ostr.h>and defining anoperator<<for your type, as done in spdlog 1.9.2, is no longer sufficient.I updated the code to compile against spdlog 1.12, and updated CMakeLists to specify spdlog 1.12 as the new minimum required version, because the header
<spdlog/fmt/ranges.h>doesn't exist in spdlog 1.9.2. Since this changes Derecho's required dependencies, it should go into a new version of Derecho, hopefully 2.4.1.