Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small CI improvements #15

Merged
merged 1 commit into from
May 17, 2024
Merged

Small CI improvements #15

merged 1 commit into from
May 17, 2024

Conversation

DigitalBrains1
Copy link
Owner

As mentioned in the GitHub Actions documentation:

Avoid using always for any task that could suffer from a critical
failure, for example: getting sources, otherwise the workflow may
hang until it times out. If you want to run a job or step
regardless of its success or failure, use the recommended
alternative: if: ${{ !cancelled() }}

(Description shamelessly copied from my colleague, Martijn Bastiaan [email protected])

As mentioned in the GitHub Actions documentation:

> Avoid using always for any task that could suffer from a critical
> failure, for example: getting sources, otherwise the workflow may
> hang until it times out. If you want to run a job or step
> regardless of its success or failure, use the recommended
> alternative: `if: ${{ !cancelled() }}`

(Description shamelessly copied from my colleague,
Martijn Bastiaan <[email protected]>)
@DigitalBrains1 DigitalBrains1 merged commit 10d7e6d into main May 17, 2024
17 checks passed
@DigitalBrains1 DigitalBrains1 deleted the finetune branch May 17, 2024 17:05
@martijnbastiaan
Copy link
Collaborator

Thief :O!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants