Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue with partial branch match #201

Merged
merged 2 commits into from
Oct 30, 2023
Merged

Conversation

jedwards4b
Copy link
Collaborator

[ 50 character, one line summary ]
Allow for partial match of branch name.

If the git ls-remote returns a 0 status then also confirm that the ref is the complete branch name by testing "refs/head/{ref}" in the output string.

User interface changes?: No

Fixes: #200

Testing:
test removed:
unit tests: all pass
system tests: most pass - submodules broken due to https://github.blog/2022-10-18-git-security-vulnerabilities-announced/
manual testing: ran tests suggested in #200

@jedwards4b jedwards4b requested a review from billsacks October 30, 2023 17:27
@jedwards4b jedwards4b self-assigned this Oct 30, 2023
Copy link
Member

@billsacks billsacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for fixing this @jedwards4b and for the helpful comment in your new conditional.

I notice that you added a print statement; I'm guessing you meant to remove that

manic/repository_git.py Outdated Show resolved Hide resolved
@jedwards4b jedwards4b merged commit 38bcc0a into ESMCI:main Oct 30, 2023
1 check passed
@jedwards4b jedwards4b deleted the partial_match branch October 30, 2023 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tag name partially matching with branch results in error when checking out
2 participants