Batch 1: Updates for paper, SE grid compatibility, bug fixes #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Support Input_Opt%correctConvUTLS to correct for convective scavenging of soluble tracers (science update, upcoming paper) - Update to UCX mpi broadcast of State_Chm%NOXCOEFF as SE grid not all CPUs have same amount of chunks and MPI code has to be moved to higher level that is aware of chunking - Update to drydep namelist for SE compatibility - Fix for incorrect SOA mapping inconsistent with published Fritz et al. (2022) methodology Signed-off-by: Haipeng Lin <[email protected]>
1 task
jimmielin
changed the title
|
All tested and ready for merging. Thanks! Checkout_externals will only work either with this fix (ESMCI/manage_externals#201) or when |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Companion PR at science repository:
Only if building with SE dycore, requires ESCOMP#904