Updates for GEOS-Chem within CESM2 - convective scavenging correction and MPI fixes #1993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lizziel
requested changes
Oct 19, 2023
jimmielin
changed the title
|
Thanks Lizzie, changelog entries added and WIP lifted. Waiting for a test run with the existing f09 (0.9x1.25) grid to finish and confirm it is working right now. |
…of soluble tracers, KppError diagnostic These updates only affect GEOS-Chem within CESM2. Signed-off-by: Haipeng Lin <[email protected]>
… CESM code. This is because NOXCOEFF_INIT is called for all chunks, but not all CPUs in the same communicator have the same amount of chunks when running on the spectral-element dycore. This will result in MPI_BCast hanging as not all CPUs in the communicator are participating in a collective call. A corresponding update inside CESM geoschem/chemistry.F90 is necessary to restore the original functionality and will be in a companion PR. Signed-off-by: Haipeng Lin <[email protected]>
jimmielin
force-pushed
the
hplin/14.1.1+cesmfix
branch
from
e7c8375 to
0ddcae2
Compare
jimmielin
force-pushed
the
hplin/14.1.1+cesmfix
branch
from
0ddcae2 to
f824252
Compare
|
Changelog updated and tested with f09 (FV dycore) and ne30 (SE dycore) grids. Should be good for review and merge. Thanks! |
lizziel
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Name and Institution (Required)
Name: Haipeng Lin
Institution: Harvard U.
Confirm you have reviewed the following documentation
Note, this PR is made based on
14.1.1as it is targeting a point release under14.1.xas well as merging intomain. Due to changes inucx_mod, there are merge conflicts againstmain.Describe the update
Input_Opt%correctConvUTLSfor a CESM-only correction of buildup of soluble tracers in the UT/LS due to decoupling of wet scavenging and convective transportState_Diag%KppErrorto GEOS-Chem within CESMChanges to the UT/LS correction (implemented in
fullchem_mod.F90) are important for results to be scientifically correct in GEOS-Chem within CESM (manuscript in prep.)The changes to UCX_Mod are essential to supporting the spectral-element dynamical core in CESM, as otherwise the model will hang as mpi_bcast is a collective operation, but on the SE dycore not all cores operate on the same number of domain chunks.
Expected changes
These updates only affect GEOS-Chem within CESM and should be zero-diff for the full-chemistry benchmark simulation.
Reference(s)
Science updates for GEOS-Chem within CESM2 will be in a paper, in prep.
Photolytic SOA sink used for correcting convective scavenging of soluble tracers solely within CESM2 environment is based on Hodzic et al. (2016) ACP (https://acp.copernicus.org/articles/16/7917/2016/acp-16-7917-2016.pdf)
Related Github Issue(s)
Companion PR at geoschem/CAM#27
Copying @lizziel.
Thanks!