Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mujoco frameskip = 0 leftover #99

Merged
merged 1 commit into from
Sep 18, 2023
Merged

Conversation

belerico
Copy link
Member

Summary

This PR solves #94. In particular:

  • frame_skip=0 is removed from the make_dict_env method
  • frame_skip has also been removed from the DMCWrapper. Action repeat can still being applied by setting env.action_repeat>=1

Type of Change

Please select the one relevant option below:

  • Bug fix (non-breaking change that solves an issue)

Checklist

Please confirm that the following tasks have been completed:

  • I have tested my changes locally and they work as expected. (Please describe the tests you performed.)
  • I have added unit tests for my changes, or updated existing tests if necessary.
  • I have updated the documentation, if applicable.
  • I have installed pre-commit and run locally for my code changes.

Thank you for your contribution! Once you have filled out this template, please ensure that you have assigned the appropriate reviewers and that all tests have passed.

@belerico belerico linked an issue Sep 16, 2023 that may be closed by this pull request
@belerico belerico changed the title FIx mujoco frameskip = 0 leftover Fix mujoco frameskip = 0 leftover Sep 16, 2023
@belerico belerico merged commit bfe50a9 into main Sep 18, 2023
7 checks passed
@belerico belerico deleted the fix/mujoco-dmc-frame-skip branch September 18, 2023 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Why is Frame_skip for gymnasium mujoco environments set to zero?
2 participants