Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unsafe annotations #67

Merged
merged 2 commits into from
Nov 16, 2022
Merged

unsafe annotations #67

merged 2 commits into from
Nov 16, 2022

Conversation

daira
Copy link
Contributor

@daira daira commented Nov 16, 2022 •
edited
Loading

This enables deny(unsafe_op_in_unsafe_fn) globally and adds unsafe annotations as necessary. fixes #65

@daira daira mentioned this pull request Nov 16, 2022
Merged
str4d
str4d requested changes Nov 16, 2022
View reviewed changes
Copy link
Contributor

@str4d str4d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR changes LGTM; only issue is how the lint is enabled.

I confirmed that the lint was stabilised in 1.51.0, and our MSRV for the Zcash Rust crates is currently 1.56.1, so we can use this lint everywhere.

rust/.cargo/config Outdated Show resolved Hide resolved
sellout
sellout approved these changes Nov 16, 2022
View reviewed changes
Copy link
Contributor

@sellout sellout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Should we also add a rust-version = "1.51" (or match the MSRV) line to Cargo.toml to catch anyone trying to build with an older version?

@daira daira force-pushed the librustzcash_0_7-unsafe-annotations branch from 23bbbe1 to 4e6ec87 Compare November 16, 2022 19:32
@str4d
Copy link
Contributor

str4d commented Nov 16, 2022

Should we also add a rust-version = "1.51" (or match the MSRV) line to Cargo.toml to catch anyone trying to build with an older version?

Yes at some point (I have already done this in the Android SDK), but doesn't have to happen in this PR (as the MSRV is unaltered by it). The actual MSRV is at least 1.56.1 (and is 1.59 over in the Android SDK, but I think that's because of an Android-specific dependency).

@daira daira merged commit d305bb7 into Electric-Coin-Company:librustzcash_0_7 Nov 16, 2022
@daira daira deleted the librustzcash_0_7-unsafe-annotations branch November 16, 2022 19:40
@daira daira mentioned this pull request Nov 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@str4d str4d str4d approved these changes

@sellout sellout sellout approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@daira @str4d @sellout