Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Free Camera Fix with "Upside Down" Extended Variant and Fix for hitbox overdraw in Lunar Pagoda #76

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

TyrannicalThesaurus
Copy link
Contributor

@TyrannicalThesaurus TyrannicalThesaurus commented Jun 4, 2024

Free Camera with mouse and keyboard had unintuitive behavior with the "Upside Down" Extended Variant. When the camera flipped, the vertical movement did not also get flipped, which made the camera feel odd to move around as one axis was inverted and the other was not. I fixed this by checking if "Upside Down" is enabled, and then inverting the center camera movement if so.

Clip From before the change:

2024-06-04_11-44-03.mp4

Clip from after the change:

2024-06-04_15-21-21.mp4

… "Upside Down" Extended Variant.

Changed the behavior such that now the camera moves exactly as if the screen were not flipped when using free cam in the "Upside Down" variant.

Clip From before the change:
https://discord.com/channels/403698615446536203/519281383164739594/1247591991001219194

Clip from after the change:
https://discord.com/channels/403698615446536203/754495709872521287/1247646546011357264
@TyrannicalThesaurus TyrannicalThesaurus changed the title Free Camera Fix with "Upside Down" Extended Variant Free Camera Fix with "Upside Down" Extended Variant and Fix for hitbox overdraw in Lunar Pagoda Jun 9, 2024
@TyrannicalThesaurus
Copy link
Contributor Author

TyrannicalThesaurus commented Jun 9, 2024

The stopwatch entity in Lunar Pagoda works by turning the screen grayscale, and then redrawing on top of the screen. This had the unintended effect of drawing over CelesteTAS's Show Hitboxes feature. I fixed this by hooking into Spirialis Helper, and adding a check to remove the redrawing when show hitboxes is enabled.

Clip from before the fix:

2024-06-08_12-34-10.mp4

Clip from after the fix:

2024-06-09_13-32-04.mp4

@psyGamer
Copy link
Member

This PR needs to be retargeted onto master. I think the only issue is me moving files around? Sorry about that.
Also about the upside down from ext-vars, what do you think about disabling that with simplified graphics?

@psyGamer
Copy link
Member

While this is now mergable, I would prefer if the fix for the stopwatch would be drawing the hitboxes after SpirialisHelper has redrawn it's entities, instead of just disabling that redrawing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants