Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor internals of CelesteTAS #91

Open
wants to merge 70 commits into
base: master
Choose a base branch
from
Open

Refactor internals of CelesteTAS #91

wants to merge 70 commits into from

Conversation

psyGamer
Copy link
Member

No description provided.

@LozenChen
Copy link
Contributor

LozenChen commented Dec 31, 2024

  1. if (Engine.FrameCounter % (ulong)Manager.PlaybackSpeed == 0) {

    This leads to a DividedByZero exception when playback speed is slow (so it rounds down to 0)
    Can reproduce this by pressing "\", the default slow forward hotkey

  2. It seems if you put a breakpoint, then the tas is saving states EVERY FRAME before that breakpoint

  3. If we press FrameAdvance when the tas is running normally, we can't go into FrameAdvance now (previously we can), this doesn't feel right

  4. If we put a breakpoint, then "RightCtrl" (the default Start/Stop hotkey) doesn't really work

@psyGamer psyGamer marked this pull request as ready for review January 1, 2025 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants