[Simplified Collect][Workflows] Create main workflow page (App)

[lakchote]

Details

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/368331
PROPOSAL:

Tests

• Verify that no errors appear in the JS console

1. Create a new Collect policy on OldDot

2. Follow the steps outlined here to enable the Collect workspace to show up on NewDot

3. Login to NewDot, then navigate to Settings > Workspaces. You should see your Collect workspace, click on it.

4. On the LHP, you should only see the menu items below, specific to paid policies:

• Profile
• Workflows
• Members

5. Click on Workflows you should see the following screen:

6. Click on the toggle switches, for the 3 items:
   - Delay submissions

• Add approvals
• Make or track payments

It should open a new sub item for each just like below

Note:
a. When you toggle Add approvals, the default approver should be the policy's owner name
b. The right switch icons do not work for now as it will be done in follow-up issues:

• https://github.com/Expensify/Expensify/issues/368335
• https://github.com/Expensify/Expensify/issues/368334
• https://github.com/Expensify/Expensify/issues/368332

7. Deselect all the toggle switches you previously toggled and open your browser's inspector > Network tab

8. Click on Delay Submissions toggle and inspect the response

policy.autoReporting should be set to true

9. Refresh the page, the switch for Delay Submissions should be on

10. Open Onyx Data, Application> IndexedDB > Onyx > keyvaluepairs (in your browser's inspector)

Go into the policy's ID data (you can find the policy ID directly in the URL).

autoreporting should be set to true just like below

11. Toggle the Delay Submissionsswitch to off and inspect the response again
    policy.autoReporting should be set to false

autoreporting should be set to false in Onyx (don't forget to refresh Onyx data)
12. Refresh the page, the switch for Delay Submissions should be off

13. Do the same (from steps 8-12) for Add approvals, look for the following:
    Toggle switch ON, expected response:

{
  "policy": {
    "approvalMode": "BASIC",
    "approver": "[email protected]", // policy's owner email
    "lastModified": 1708592956718697,
    "isAutoApprovalEnabled": true
  }
}

Expected Onyx values:

Toggle switch OFF, expected response:

{
  "policy": {
    "approvalMode": "OPTIONAL",
    "approver": "[email protected]", // policy's owner email
    "lastModified": 1708592956718697,
    "isAutoApprovalEnabled": false
  }
}

Expected Onyx values:

Offline tests

Repeat the same steps as in the video below, ensuring you have the same look and feel.

Screen.Recording.2024-02-23.at.1.02.30.AM.mov

QA Steps

• Verify that no errors appear in the JS console
  Same as in Tests section above.

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native


iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

[lakchote]

WIP

Currently did the part and the parts before that here in the DD.

Screenshot on how it is currently:

What is left:

• add icon before Workflows title now that the PR for Members has been merged
• add border dots between each icon
• fix alignment of icons vertically?
• display the sub components correctly in the UI
• set policy Onyx keys
• try mobile see if the UI is looking good

[trjExpensify]

@lakchote are all the other menu items in the LHN just because you're testing the development in a free workspace or something? As Workflows will only be set and configured on collect workspaces (and later control). CC: @luacmartins @mountiny

[mountiny]

That seems like a free workspace

[lakchote]

@lakchote are all the other menu items in the LHN just because you're testing the development in a free workspace or something? As Workflows will only be set and configured on collect workspaces (and later control). CC: @luacmartins @mountiny

Yes, I'm just testing things right now to have the correct look and feel. I'll ensure it's only available for Collect workspaces.

[lakchote]

Screen.Recording.2024-02-14.at.18.14.45.mov

What is left:

• add border dots between each icon
• fix alignment of icons vertically
• set policy Onyx keys
• try mobile see if the UI is looking good

[lakchote]

@lakchote lint is failing

Lint tests are passing now.

@ishpaul777 waiting for the video to upload. It looks good

[lakchote]

Thanks @lakchote can you please retest with a actual collect policy i am having some issues setting it up, for now i was testing with modifying conditional but there are a few changes that would idealy be tested with a actual collect policy.

For some reason, GH won't let me upload my video (it's stuck)

I've put it here

[ishpaul777]

Looks good 🎉🚀 tests well

I dont consider this as blocker(may be not even related) just mentioning so it, toggling on a option seems to select submenu item content see vid 👇👇

Screen.Recording.2024-02-23.at.11.40.22.PM.mov

[melvin-bot]

@youssef-lr Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[melvin-bot]

🎯 @ishpaul777, thanks for reviewing and testing this PR! 🎉

An E/App issue has been created to issue payment here: #37157.

[luacmartins]

I dont consider this as blocker(may be not even related) just mentioning so it, toggling on a option seems to select submenu item content see vid

I didn't experience this during my tests. Was there some pre-requisite to reproduce that, e.g. selecting the toggle before or something?

[lakchote]

I dont consider this as blocker(may be not even related) just mentioning so it, toggling on a option seems to select submenu item content see vid

I didn't experience this during my tests. Was there some pre-requisite to reproduce that, e.g. selecting the toggle before or something?

Didn't experience it either too.

Was just able to reproduce it.

Toggle a switch and reload the page
Toggle off the switch and toggle it back on, the sub menu item will be selected

[luacmartins]

I'd say that's not a blocker for this PR.

comments have been addressed

[ishpaul777]

Just toggle on/off a option multiple times quickly, it will be reporoducible

[luacmartins]

Created an issue for it here

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[ishpaul777]

Can you assign me as c+ if this goes external 🙃

[luacmartins]

done

[ishpaul777]

Thank you 🙃🙂

[OSBotify]

🚀 Deployed to staging by https://github.com/luacmartins in version: 1.4.44-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.44-13 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[ishpaul777]

This caused #36345, we have had tp wrap this view in a scrollview